Add SortedAttributesRule #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
luciawlli
approved these changes
Oct 15, 2020
jimmylai
reviewed
Oct 15, 2020
| """, | ||
| ) | ||
| ] | ||
| ONCALL_SHORTNAME = "ig_creation_backend" |
There was a problem hiding this comment.
This is not needed.
Suggested change
| ONCALL_SHORTNAME = "ig_creation_backend" |
There was a problem hiding this comment.
Nice catches 👍 . I'm pushing a new version that solves all the comments.
| return | ||
| self.report( | ||
| node, | ||
| self.MESSAGE, |
There was a problem hiding this comment.
self.MESSAGE is used by default.
Suggested change
| self.MESSAGE, |
| """ | ||
| ) | ||
| ] | ||
| MESSAGE: str = "It appears you are using the @sorted directive and the class variables are unsorted. See the lint autofix suggestion." |
There was a problem hiding this comment.
Suggested change
| MESSAGE: str = "It appears you are using the @sorted directive and the class variables are unsorted. See the lint autofix suggestion." | |
| MESSAGE: str = "It appears you are using the @sorted-attributes directive and the class variables are unsorted. See the lint autofix suggestion." |
resolve 'future feature annotations is not defined' address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support sorting class attributes alphabetically with autofix.
Test Plan
Unit test by running
tox -e py37All tests passed!