Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AddMissingHeaderRule to check copyright header comments #142

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Oct 2, 2020

Summary

Add this to automatically check and fix the copyright header in Fixit source code.

It's a generic and configurable rule can be used to enforce any header comments in a given path pattern.

Test Plan

  1. tox -e py38 -- fixit.tests.AddMissingHeaderRule
  2. update .fixit.config.yaml and run python -m fixit.cli.apply_fix fixit --rules AddMissingHeaderRule which fixes files:
  • fixit/cli/tests/__init__.py
  • fixit/common/tests/__init__.py

@jimmylai jimmylai requested review from Kronuz, zsol and luciawlli October 2, 2020 22:17
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2020
@jimmylai jimmylai merged commit 1f11c18 into Instagram:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants