Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update testing docs to use tox for simplicity #138

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Sep 25, 2020

Summary

Update testing docs to use tox for simplicity and fix some RST formatting issues.

Test Plan

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2020
@jimmylai jimmylai requested review from luciawlli and zsol September 25, 2020 16:39
README.rst Outdated
@@ -81,26 +81,24 @@ to format code. To format changes to be conformant, run the following in the roo
tox -e autofix

To run all tests, you'll need to install `tox <https://tox.readthedocs.io/en/latest/>`_
and do the following in the root:
and do the following in the root: (use py37, py38 to chose from Python version 3.7 or 3.8)::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/chose/choose

@jimmylai jimmylai merged commit 42cff20 into Instagram:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants