Add no namedtuple rule

[lukuang]

Summary

Introduce a rule that enforces the use of dataclass instead of NamedTuple for better customization and inheritance support

Test Plan

unitests

[lukuang]

Not sure about the test errors here. Can anyone help me?

[isidentical]

I don't know how much community feedback was involved with this rule, but IMHO it is a terrible idea. namedtuple's are totally different than dataclasses on different use cases (including performance, usage etc). I'm totally -1 on this.

[jimmylai]

Not sure about the test errors here. Can anyone help me?

@lukuang if you check the error message on Github builds, you'll find this:
ERROR: /Users/runner/work/Fixit/Fixit/fixit/rules/no_namedtuple.py Imports are incorrectly sorted and/or formatted.
The code format doesn't comply and you can fix it by running tox -e autofix locally.

[jimmylai]

I don't know how much community feedback was involved with this rule, but IMHO it is a terrible idea. namedtuple's are totally different than dataclasses on different use cases (including performance, usage etc). I'm totally -1 on this.

Rules in Fixit doesn't mean they're standard Python convention that needs to be applied everywhere.
Rules can be disabled in config file via the block_list_rules.
https://fixit.readthedocs.io/en/latest/getting_started.html#Configuration-File

We found this convention is useful for us for reasons including consistency, performance and usability. So we built this rule.
PEP-557 explains some NamedTuple caveats that can be avoided by dataclass. This is a reference of performance benchmark.
https://medium.com/@jacktator/dataclass-vs-namedtuple-vs-object-for-performance-optimization-in-python-691e234253b9

[jimmylai]

Even though this works, the convention is to import those helpers from fixit to be simpler and consistent to other rules.
https://fixit.readthedocs.io/en/latest/test_a_lint_rule.html#Writing-Unit-Tests

[jimmylai]

@lukuang thanks for contributing!
I updated the message and docstring a bit to make it more clear and use RST formats. Let me know how do you like it.

[lukuang]

@lukuang thanks for contributing!
I updated the message and docstring a bit to make it more clear and use RST formats. Let me know how do you like it.

LGTM! Thanks @jimmylai, it is more clear now. Please go ahead and 🚢