Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix DISALLOW_COPY_AND_ASSIGN macro argument. #10

Merged
merged 1 commit into from
Sep 25, 2018
Merged

BUG: Fix DISALLOW_COPY_AND_ASSIGN macro argument. #10

merged 1 commit into from
Sep 25, 2018

Conversation

jhlegarreta
Copy link
Member

Fix DISALLOW_COPY_AND_ASSIGN macro agument for the
itk::ConnectedThresholdSegmentationModule class.

Fixes compilation errors (MSVC 2015):

1>c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(40):
error C2059: syntax error: 'const'
1>
c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(82):
note: see reference to class template instantiation
'itk::ConnectedThresholdSegmentationModule<NDimension>' being compiled
1>c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(40):
error C2238: unexpected token(s) preceding ';'

@jhlegarreta
BUG: Fix DISALLOW_COPY_AND_ASSIGN macro argument.
c14b3cd 
Fix `DISALLOW_COPY_AND_ASSIGN` macro agument for the
`itk::ConnectedThresholdSegmentationModule` class.

Fixes compilation errors (MSVC 2015):
```
1>c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(40):
error C2059: syntax error: 'const'
1>
c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(82):
note: see reference to class template instantiation
'itk::ConnectedThresholdSegmentationModule<NDimension>' being compiled
1>c:\sources\lesionsizingtoolkit\include\itkConnectedThresholdSegmentationModule.h(40):
error C2238: unexpected token(s) preceding ';'
```
@jhlegarreta jhlegarreta mentioned this pull request Sep 25, 2018
Closed
thewtex
thewtex approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch.

@thewtex thewtex merged commit 23046af into InsightSoftwareConsortium:master Sep 25, 2018
@jhlegarreta jhlegarreta deleted the FixDisallowCopyAndAssingArgument branch September 25, 2018 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhlegarreta @thewtex