Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add Python Example GlobalRegistrationOfTwoImages #387

Merged
merged 2 commits into from
May 25, 2022
Merged

ENH: Add Python Example GlobalRegistrationOfTwoImages #387

merged 2 commits into from
May 25, 2022

Conversation

nhjohnston
Copy link

Created python version of the example for GlobalRegistrationOfTwoImages, including the CreateSphereImage and CreateEllipseImage functions. Produces same ellipse image, circle image, and output image as the C++ example

@github-actions github-actions bot added area:Registration Issues affecting the Registration module language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels May 23, 2022
@nhjohnston nhjohnston marked this pull request as ready for review May 24, 2022 11:55
tbirdso
tbirdso reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nhjohnston! Please run Python styling on Code.py to resolve the linting failure:

python -m pip install black
python -m black Code.py

tbirdso
tbirdso approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tbirdso tbirdso merged commit 8cbc927 into InsightSoftwareConsortium:master May 25, 2022
@tbirdso
Copy link
Contributor

tbirdso commented May 25, 2022

🎊 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

Assignees
No one assigned
Labels
area:Registration Issues affecting the Registration module language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhjohnston @tbirdso