Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add 1D FFT Example #379

Merged
merged 2 commits into from
Nov 25, 2024
Merged

ENH: Add 1D FFT Example #379

merged 2 commits into from
Nov 25, 2024

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented May 20, 2022 •
edited
Loading

Takes in mouse liver RF image (public data from ITKUltrasound testing) and performs FFT along scanline.

Also adds option in compare_to_baseline CMake function to optionally allow only Python (no C++) baseline test creation.

Input

rf-input

Output modulus

MouseLiverModulusOutput

Output phase

MouseLiverPhaseOutput

Closes #354.

@tbirdso tbirdso requested a review from thewtex May 20, 2022 19:57
@github-actions github-actions bot added area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels May 20, 2022
@tbirdso
Copy link
Contributor Author

tbirdso commented May 20, 2022

Fixed reference to input screenshot in .rst documentation.

@tbirdso
Copy link
Contributor Author

tbirdso commented May 23, 2022

It looks like there is a larger issue of test dependencies here, the log file shows that ComputeFFTInOneDimension baseline comparisons are run before the ComputeFFTInOneDimension test. It appears that test dependencies are being set in CMake as one would expect. Need to dig deeper into this.

@tbirdso
Copy link
Contributor Author

tbirdso commented May 23, 2022

Note that it also looks like we will need to resolve #362 before this one can be merged as 1D FFT classes were added after the 5.2.0 release.

@hjmjohnson hjmjohnson merged commit 8b7f38d into InsightSoftwareConsortium:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 1D FFT examples
3 participants
@tbirdso @thewtex @hjmjohnson