Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: ENABLE_QUICKVIEW code updates #320

Merged
merged 3 commits into from
Jan 19, 2022
Merged

COMP: ENABLE_QUICKVIEW code updates #320

merged 3 commits into from
Jan 19, 2022

Conversation

hjmjohnson
Copy link
Member

Conditional code for ENABLE_QUICKVIEW no
longer compiled.

Changes to use simpler "auto image = ReadImage<>()"
function changed the signature of the variable type
for image.

@hjmjohnson
COMP: ENABLE_QUICKVIEW code updates
89ccb55 
Conditional code for ENABLE_QUICKVIEW no
longer compiled.

Changes to use simpler "auto image = ReadImage<>()"
function changed the signature of the variable type
for image.
@hjmjohnson hjmjohnson self-assigned this Jan 17, 2022
@hjmjohnson hjmjohnson requested a review from dzenanz January 17, 2022 20:53
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Segmentation Issues affecting the Segmentation module language:C++ Changes to C++ examples type:Compiler Compiler support or related warnings labels Jan 17, 2022
@hjmjohnson
Copy link
Member Author

Lint failure seems to be a problem with the docker image missing a file.

@hjmjohnson
COMP: Remove unnecessary shadow definition
1e9e3fd 
SphinxExamples/src/Filtering/BinaryMathematicalMorphology/PruneBinaryImage/Code.cxx:43:9: warning: declaration shadows a type alias in namespace '(anonymous)' [-Wshadow]
  using ImageType = itk::Image<unsigned char, 2>;
        ^
SphinxExamples/src/Filtering/BinaryMathematicalMorphology/PruneBinaryImage/Code.cxx:30:7: note: previous declaration is here
using ImageType = itk::Image<unsigned char, 2>;
      ^
@hjmjohnson
COMP: Resolve deprecation warning for SphinxExamples
e7fcf6d 
CMake Warning at CMake/ITKFactoryRegistration.cmake:230 (message):
  ITK_NO_IO_FACTORY_REGISTER_MANAGER CMake variable is deprecated.  Use
  ITK_NO_IMAGEIO_FACTORY_REGISTER_MANAGER

Resolves: #319
@github-actions github-actions bot added area:IO Issues affecting the IO module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jan 17, 2022
thewtex
thewtex approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hjmjohnson !

@hjmjohnson hjmjohnson merged commit 6b9e0fe into master Jan 19, 2022
@hjmjohnson hjmjohnson deleted the fix-quickview-examples branch August 19, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Segmentation Issues affecting the Segmentation module language:C++ Changes to C++ examples type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjmjohnson @thewtex @dzenanz