Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added ThinImage Python script #287

Merged

Conversation

kian-weimer
Copy link
Contributor

Created a Python ThinImage example based off of the existing C++ example.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good even as is. Inline improvements optional.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

thewtex
thewtex previously requested changes Jun 1, 2021
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kian-weimer thanks for the contribution!

A few style issues are noted inline.

@thewtex thewtex requested a review from hjmjohnson June 1, 2021 19:39
@dzenanz dzenanz merged commit c1ca53f into InsightSoftwareConsortium:master Jun 2, 2021
@kian-weimer kian-weimer deleted the PythonExamples branch June 2, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants