Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Do not change location when launching VS development shell #64

Merged

Conversation

SimonRit
Copy link
Collaborator

@SimonRit SimonRit commented Jul 3, 2023

RTK's GH actions were failing, see here. This patch seems to solve the issue, see here. I had encountered a similar issue before in Cuda GH actions (here and here), I don't know what triggers different behaviors...

@dzenanz dzenanz requested a review from tbirdso July 3, 2023 13:06
Copy link
Collaborator

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@tbirdso tbirdso merged commit d8d13e9 into InsightSoftwareConsortium:main Jul 3, 2023
N-Dekker added a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 20, 2023
Upgraded ITKRemoteModuleBuildTestPackageAction to the latest revision from its
main, from 2023-07-04. Aims to fix GitHub CI failures, especially from
"cxx-build-workflow / build-test-cxx (windows-2022)".

Including:

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#65
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@edd0a43
  BUG: Add missing space before closing bracket in if statements

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#64
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@1514c2c
  COMP: Do not change location when launching VS development shell

Suggested by Dženan Zukić and Tom Birdsong.
dzenanz pushed a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 20, 2023
Upgraded ITKRemoteModuleBuildTestPackageAction to the latest revision from its
main, from 2023-07-04. Aims to fix GitHub CI failures, especially from
"cxx-build-workflow / build-test-cxx (windows-2022)".

Including:

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#65
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@edd0a43
  BUG: Add missing space before closing bracket in if statements

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#64
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@1514c2c
  COMP: Do not change location when launching VS development shell

Suggested by Dženan Zukić and Tom Birdsong.
@SimonRit SimonRit deleted the SkipAutomaticLocation branch June 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants