Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add/update notebooks showing the pixel type support #224

Merged
merged 3 commits into from
May 30, 2023
Merged

ENH: Add/update notebooks showing the pixel type support #224

merged 3 commits into from
May 30, 2023

Conversation

ntatsisk
Copy link
Collaborator

@ntatsisk ntatsisk commented May 25, 2023 •
edited
Loading

itk-elastix >=v0.17.0 supports any scalar pixel type. This PR:

  • Adds a notebook example demonstrating this functionality.
  • Updates notebook ITK_Example09_PointSetAndMaskTransformation to read the masks as itk.UC types

EDIT: Part of the code was based on reply #211 (comment) from @NHPatterson

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dzenanz
dzenanz approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from minor inline comment/question.

@ntatsisk ntatsisk force-pushed the notebooks-pixel-types branch from b80efd2 to 270c4dd Compare May 26, 2023 09:02
@ntatsisk
Copy link
Collaborator Author

ntatsisk commented May 26, 2023 •
edited
Loading

Hi @N-Dekker, can you also review the notebook to see if it covers the image type functionality added to itk-elastix?

@ntatsisk ntatsisk requested a review from N-Dekker May 26, 2023 09:07
@N-Dekker
Copy link
Collaborator

Thanks @ntatsisk I'll try it out using my latest conda environment 😃

@N-Dekker
Copy link
Collaborator

No show stoppers, just minor suggestions.

@ntatsisk ntatsisk force-pushed the notebooks-pixel-types branch from 270c4dd to 0a60fc5 Compare May 30, 2023 11:58
N-Dekker
N-Dekker approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments 👍 👍

@dzenanz dzenanz merged commit 4fbdc9c into InsightSoftwareConsortium:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Dekker N-Dekker N-Dekker approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntatsisk @N-Dekker @dzenanz