Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ENH: Add performance benchmark CI builds #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Mar 21, 2019

No description provided.

@thewtex thewtex force-pushed the ci-performance-builds branch 8 times, most recently from 6a32231 to ce113c5 Compare March 22, 2019 21:29
@jhlegarreta
Copy link
Member

Speechless. Awesome.

@thewtex thewtex force-pushed the ci-performance-builds branch 5 times, most recently from 71f2cc5 to 111d88b Compare March 29, 2019 16:55
@thewtex thewtex force-pushed the ci-performance-builds branch 2 times, most recently from c0f2bbb to 289543a Compare April 8, 2019 22:22
@thewtex thewtex force-pushed the ci-performance-builds branch 4 times, most recently from fa20324 to 96b6114 Compare April 10, 2019 01:52
@thewtex thewtex marked this pull request as ready for review April 10, 2019 01:53
@thewtex thewtex force-pushed the ci-performance-builds branch from 96b6114 to b1d0d43 Compare April 11, 2019 20:39
@thewtex thewtex force-pushed the ci-performance-builds branch from b1d0d43 to 9cc56fa Compare April 23, 2019 22:26
@kwrobot-v1
Copy link

kwrobot-v1 bot commented Apr 23, 2019

Errors:

  • Failed to run the checks: service error.

@thewtex
Copy link
Member Author

thewtex commented Apr 24, 2019

Errors:

* Failed to run the checks: `service error`.

CC @bradking @mathstuf

@thewtex thewtex force-pushed the ci-performance-builds branch from 9cc56fa to 1e53cfb Compare April 24, 2019 15:50
@mathstuf
Copy link
Contributor

Hmm. Seems we got a timeout on one of our queries.

Do: check

@thewtex thewtex force-pushed the ci-performance-builds branch 3 times, most recently from 0948b8f to 698efc6 Compare April 25, 2019 13:54
@thewtex thewtex force-pushed the ci-performance-builds branch from 4705fa7 to c93e0c6 Compare December 20, 2019 19:41
@thewtex
Copy link
Member Author

thewtex commented Dec 20, 2019

/azp run ITK.macOS

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@stale
Copy link

stale bot commented Apr 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Apr 19, 2020
@thewtex thewtex removed the status:Backlog Postponed without a fixed deadline label Apr 20, 2020
@thewtex thewtex added this to the ITK v5.2.0 milestone Apr 20, 2020
@stale
Copy link

stale bot commented Aug 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Aug 19, 2020
@thewtex thewtex modified the milestones: ITK v5.2.0, ITK v5.3.0 Mar 3, 2021
@stale stale bot removed the status:Backlog Postponed without a fixed deadline label Mar 3, 2021
@stale
Copy link

stale bot commented Jul 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Jul 2, 2021
@dzenanz dzenanz modified the milestones: ITK 5.3.0, ITK 6.0.0 Dec 29, 2021
@stale stale bot removed the status:Backlog Postponed without a fixed deadline label Dec 29, 2021
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Apr 28, 2022
@hjmjohnson
Copy link
Member

@thewtex This is now ready for updating (rebasing) and reconsidering!

@stale stale bot removed the status:Backlog Postponed without a fixed deadline label May 31, 2024
@jhlegarreta jhlegarreta force-pushed the ci-performance-builds branch from c93e0c6 to 8e4c0f3 Compare June 1, 2024 17:52
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jun 1, 2024
@jhlegarreta jhlegarreta force-pushed the ci-performance-builds branch from 8e4c0f3 to c6b6b60 Compare June 1, 2024 17:53
@jhlegarreta
Copy link
Member

jhlegarreta commented Jun 1, 2024

Updated macOS version from 10.13:
c93e0c6#diff-c8d4e43125ff7fbe0d808694e0b2ab37de80808b1d9a54fed631330117d3cd4bR90

to macOS 11, and Python from 3.7 to 3.9:
c93e0c6#diff-c8d4e43125ff7fbe0d808694e0b2ab37de80808b1d9a54fed631330117d3cd4bR104

Preferred to avoid style changes to the existing parts, e.g.:
c93e0c6#diff-c8d4e43125ff7fbe0d808694e0b2ab37de80808b1d9a54fed631330117d3cd4bR8

Not sure if this will be enough to have this working.

If Azure allows to re-use workflows, cleanest would be to relocate the performance benchmarking part to a separate file so that the macOS build part can report its status regardless of the benchmarking part.

@jhlegarreta
Copy link
Member

So the benchmarks add 22 minutes;
https://dev.azure.com/itkrobotmacos/ITK.macOS/_build/results?buildId=11489&view=logs&j=68e22afd-607b-5133-9236-337c135f0832

If this is deemed excessive, they could be triggered e.g. once or twice a week.

The next thing will be how to display those reports on a website.

@thewtex
Copy link
Member Author

thewtex commented Jun 3, 2024

I started an ASV port on the ITKPerformanceBenchmarking repository. Eventually we should be able to run asv compare similar to what @yarikoptic did with datalad.

@yarikoptic
Copy link

FWIW we ran into some minor issues with recent asv and our setups, just in case you do too -- might want to restrict for now to < 0.6.2 and make sure that you have asv[virtualenv] in your setup*, as we did in https://github.com/con/fscacher/pull/91/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R49 which is yet another project of ours which does similar benchmarking on CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants