Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Prefer compile-time constexpr #5110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

STYLE: Prefer compile-time constexpr #5110

wants to merge 3 commits into from

Conversation

hjmjohnson
Copy link
Member

The values of m_Factor* are known at compile-
time, so compute them only at compile-time.

PR Checklist

@hjmjohnson
STYLE: Prefer compile-time constexpr
8f5f9b1 
The values of m_Factor* are known at compile-
time, so compute them only at compile-time.
@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Dec 22, 2024
@hjmjohnson hjmjohnson self-assigned this Dec 22, 2024
@github-actions github-actions bot added area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming) labels Dec 22, 2024
@hjmjohnson hjmjohnson requested a review from N-Dekker December 24, 2024 14:37
@hjmjohnson
STYLE: Move static constexpr to local scope where needed
3ca7ee5 
These constant values are only used inside operator(), so move local
(static constexpr) variable of operator() instead of a member variable
of the class.
@hjmjohnson
STYLE: Prefer static member function Sinc
1e0de79 
Member function can be made static.

Redundant 'inline' specifier on a function declared entirely inside a
class definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Dekker N-Dekker N-Dekker left review comments

@dzenanz dzenanz dzenanz approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
ITK 6.0 Beta 1
Development

Successfully merging this pull request may close these issues.
3 participants
@hjmjohnson @dzenanz @N-Dekker