Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: PrintSlice re-used variable name #5109

Merged

Conversation

hjmjohnson
Copy link
Member

The variable name s was used as an input and a loop variable. Split the names to clearly indicate the iteration variable intent.

PR Checklist

@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Dec 22, 2024
@hjmjohnson hjmjohnson self-assigned this Dec 22, 2024
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming) labels Dec 22, 2024
@hjmjohnson
Copy link
Member Author

/azp
ITK.macOS

@hjmjohnson
Copy link
Member Author

/azp ITK.macOS

1 similar comment
@hjmjohnson
Copy link
Member Author

/azp ITK.macOS

The variable name s was used as an input and a loop variable.
Split the names to clearly indicate the iteration variable
intent.
@hjmjohnson hjmjohnson force-pushed the fix-test-printself-var branch from 6e57af1 to ede5845 Compare December 25, 2024 01:35
@hjmjohnson
Copy link
Member Author

Failing test is not related:

107:  Test 009: Specialised version is faster                         --> **FAILED**
107: max_dsq: 4.77266e-27  mean_dsq: 2.40117e-29
107:  Test 010: Specialised version gives similar results             -->   PASSED
107:  Test 011: Numerically difficult values are ok v1                -->  should be 4199, is 4199, difference 1.81899e-12,   PASSED
107:  Test 012: Numerically difficult values are ok v2                -->  should be 4199, is 4199, difference 1.81899e-12,   PASSED
107:  Test 013: Numerically difficult values are ok v3                -->  should be 4801, is 4801, difference 4.54747e-12,   PASSED
107: -----------------------------------------------------------------------------
107: test_symmetric_eigensystem Test Summary: 12 tests succeeded, 1 test failed		*****
107: -----------------------------------------------------------------------------
 122/3246 Test  #107: vnl_algo_test_symmetric_eigensystem ....................................................................***Failed    0.20 sec

Addressed upstream in VXL vxl/vxl@6f2a5eb

vxl/vxl#970

@dzenanz dzenanz merged commit 42e9ccb into InsightSoftwareConsortium:master Dec 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants