Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOR RELEASE BUG: Fix 32-bit truncation on VectorImage Accessor #5072

Merged

Conversation

blowekamp
Copy link
Member

Initial bug reported in SimpleITK/SimpleITK#2220.

On 64-bit windows system, truncation to 32-bit (unsigned long) was occouring when setting VectorImages with over 4GB buffers.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp blowekamp requested a review from thewtex December 15, 2024 11:23
@github-actions github-actions bot added the area:Core Issues affecting the Core module label Dec 15, 2024
Initial bug reported in SimpleITK/SimpleITK#2220.

On 64-bit windows system, truncation to 32-bit (unsigned long) was
occouring when setting VectorImages with over 4GB buffers.
@blowekamp blowekamp force-pushed the fix_vector_image_fail branch from 9cdf4c6 to ee63f5e Compare December 15, 2024 18:59
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 💯

@thewtex thewtex merged commit 273d665 into InsightSoftwareConsortium:release-5.4 Dec 16, 2024
24 of 25 checks passed
@thewtex
Copy link
Member

thewtex commented Dec 16, 2024

@blowekamp thanks!

I will give release-5.4 a few days, then tag v5.4.2 as you suggested.

@blowekamp
Copy link
Member Author

I updated SimpleITK to the current release-5.4 hash, and the SimpleITK issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants