Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ITK_FUTURE_DEPRECATED macro, use it in itkSingleton.h and for CoordRepType #4999

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Add ITK_FUTURE_DEPRECATED macro, use it in itkSingleton.h and for CoordRepType #4999

merged 3 commits into from
Dec 2, 2024

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Nov 28, 2024 •
edited
Loading

In general, ITK_FUTURE_DEPRECATED is intended to be used instead of [[deprecated]], when a feature is marked ITK_FUTURE_LEGACY_REMOVE, and when such "deprecated" warnings may be disturbing to legacy users, who have intentionally enabled legacy support.

Used the macro for the deprecated SetGlobalInstance and Singleton overloads in itkSingleton.h (which were both already marked ITK_FUTURE_LEGACY_REMOVE), and the CoordRepType aliases.

@github-actions github-actions bot added the area:Core Issues affecting the Core module label Nov 28, 2024
@N-Dekker N-Dekker marked this pull request as ready for review November 29, 2024 11:07
@N-Dekker N-Dekker force-pushed the ITK_FUTURE_DEPRECATED branch 2 times, most recently from 91fb524 to d1a63b7 Compare December 2, 2024 10:51
@N-Dekker
ENH: Add internal ITK_FUTURE_DEPRECATED(message) macro
dffcc63 
To be used instead of `[[deprecated(message)]]`, when a feature is marked
`ITK_FUTURE_LEGACY_REMOVE`.
@N-Dekker
ENH: ITK_FUTURE_DEPRECATED for SetGlobalInstance and Singleton overloads
23a0912 
These specific "deprecated" warnings should not appear when legacy support is
enabled.
@N-Dekker
ENH: ITK_FUTURE_DEPRECATED for CoordRepType aliases
544b727 
The `CoordRepType` aliases are only intended to be removed in the future
(`ITK_FUTURE_LEGACY_REMOVE`), so these specific "deprecated" warnings should
not appear when legacy support is still enabled.
@N-Dekker N-Dekker force-pushed the ITK_FUTURE_DEPRECATED branch from d1a63b7 to 544b727 Compare December 2, 2024 11:12
@github-actions github-actions bot added area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module labels Dec 2, 2024
hjmjohnson
hjmjohnson approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-Dekker Very nice.

FYI: There are two related changes that you might want to consider a similar change to:

 git grep "CoordRepType" |grep -F -v deprecated        
Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshToQuadEdgeMeshFilter.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshToQuadEdgeMeshFilter.h:  using OutputCoordRepType = typename OutputMeshType::CoordinateType;
Modules/Core/Transform/include/itkBSplineTransformInitializer.h:  using ImagePointCoordRepType = typename ImagePointType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  using OutputCoordRepType = typename OutputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  itkSetMacro(Radius, InputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  itkGetConstMacro(Radius, InputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  InputCoordRepType m_Radius{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType max_length(0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:    InputCoordRepType length(0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const r = this->RadiusMaxSquare();
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const two_r = 2.0 * r;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const inv_two_r = 1.0 / two_r;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType dist = pt1.SquaredEuclideanDistanceTo(pt2);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  std::vector<InputCoordRepType> tetas(NbBoundaryPt, 0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  tetas[0] = static_cast<InputCoordRepType>(std::acos((two_r - dist) * inv_two_r));
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const a = (2.0 * itk::Math::pi) / tetas[NbBoundaryPt - 1];
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:    pt1[0] = this->m_Radius * static_cast<InputCoordRepType>(std::cos(a * tetas[j]));
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:    pt1[1] = this->m_Radius * static_cast<InputCoordRepType>(std::sin(a * tetas[j]));
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:BorderQuadEdgeMeshFilter<TInputMesh, TOutputMesh>::RadiusMaxSquare() -> InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType oRmax(0.);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:    InputCoordRepType const r =
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:      static_cast<InputCoordRepType>(center.SquaredEuclideanDistanceTo(input->GetPoint(BoundaryPtIterator->first)));
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const invNbOfPoints = 1.0 / static_cast<InputCoordRepType>(input->GetNumberOfPoints());
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  std::vector<InputCoordRepType> Length(NbBoundaryPt + 1, 0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType TotalLength(0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:      InputCoordRepType const distance = PtOrg.EuclideanDistanceTo(PtDest);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const EdgeLength = 2.0 * this->m_Radius;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkBorderQuadEdgeMeshFilter.hxx:  InputCoordRepType const ratio = 4.0 * EdgeLength / TotalLength;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  using typename Superclass::InputCoordRepType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  using typename Superclass::OutputCoordRepType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:    BoundingBox<InputPointIdentifier, Self::PointDimension, InputCoordRepType, InputPointsContainer>;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  itkSetMacro(AbsoluteTolerance, InputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  itkGetConstMacro(AbsoluteTolerance, InputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  itkSetClampMacro(RelativeTolerance, InputCoordRepType, 0.0, 1.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  itkGetConstMacro(RelativeTolerance, InputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  MergePoints(const InputCoordRepType absoluteToleranceSquared);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  InputCoordRepType m_AbsoluteTolerance{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.h:  InputCoordRepType m_RelativeTolerance{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.hxx:  this->m_AbsoluteTolerance = InputCoordRepType{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.hxx:  this->m_RelativeTolerance = InputCoordRepType{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.hxx:  InputCoordRepType const zeroValue{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.hxx:  InputCoordRepType absoluteToleranceSquared = this->m_AbsoluteTolerance * this->m_AbsoluteTolerance;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkCleanQuadEdgeMeshFilter.hxx:CleanQuadEdgeMeshFilter<TInputMesh, TOutputMesh>::MergePoints(const InputCoordRepType absoluteToleranceSquared)
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:  using OutputCoordRepType = typename OutputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:    OutputCoordRepType const sq_norm1A = v1A * v1A;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:    OutputCoordRepType const sq_norm1B = v1B * v1B;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:    OutputCoordRepType const sq_norm2A = v2A * v2A;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkDelaunayConformingQuadEdgeMeshFilter.h:    OutputCoordRepType const sq_norm2B = v2B * v2B;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  using typename Superclass::OutputCoordRepType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  using CoefficientMapType = std::unordered_map<OutputQEPrimal *, OutputCoordRepType, HashOutputQEPrimal>;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  using AreaMapType = std::unordered_map<OutputPointIdentifier, OutputCoordRepType>;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  using RowType = std::unordered_map<OutputPointIdentifier, OutputCoordRepType>;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  OutputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  OutputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:  FillMatrixRow(OutputPointIdentifier iId, unsigned int iDegree, OutputCoordRepType iWeight, RowType & ioRow);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:    Triple(OutputPointIdentifier iV, OutputCoordRepType iWeight, unsigned int iDegree)
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.h:    OutputCoordRepType    m_Weight;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:  OutputPointIdentifier iId) -> OutputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:  OutputCoordRepType oW{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:  -> OutputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:    OutputCoordRepType const area = TriangleType::ComputeMixedArea(p[0], p[1], p[2]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:      return OutputCoordRepType{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:    return OutputCoordRepType{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:  OutputCoordRepType    iWeight,
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:        ioRow.insert(std::pair<OutputPointIdentifier, OutputCoordRepType>(vId, t.m_Weight));
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:      OutputCoordRepType ww{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:      OutputCoordRepType w{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilter.hxx:              OutputCoordRepType         mixedArea = NumericTraits<OutputCoordRepType>::OneValue();
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.h:  using typename Superclass::OutputCoordRepType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.hxx:    this->FillMatrixRow(vId1, this->m_Order, NumericTraits<OutputCoordRepType>::OneValue(), row);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.hxx:      const OutputCoordRepType    weight = rIt->second;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.hxx:      auto dx = static_cast<OutputCoordRepType>(X[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.hxx:      auto dy = static_cast<OutputCoordRepType>(Y[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithHardConstraints.hxx:      auto dz = static_cast<OutputCoordRepType>(Z[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  using typename Superclass::OutputCoordRepType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  itkSetMacro(Lambda, OutputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  itkGetMacro(Lambda, OutputCoordRepType);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  SetLocalLambda(OutputPointIdentifier vId, OutputCoordRepType iL);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  OutputCoordRepType m_Lambda{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  OutputCoordRepType m_LambdaSquare{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.h:  std::unordered_map<OutputPointIdentifier, OutputCoordRepType> m_LocalLambdaSquare{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:  OutputCoordRepType    iL)
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:    this->FillMatrixRow(vId1, this->m_Order, NumericTraits<OutputCoordRepType>::OneValue(), row);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      const OutputCoordRepType    weight = rIt->second;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      OutputCoordRepType l2 = m_LambdaSquare;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      typename std::unordered_map<OutputPointIdentifier, OutputCoordRepType>::const_iterator const lambdaIt =
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      auto x = static_cast<OutputCoordRepType>(X[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      auto y = static_cast<OutputCoordRepType>(Y[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraints.hxx:      auto z = static_cast<OutputCoordRepType>(Z[internalId]);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkParameterizationQuadEdgeMeshFilter.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkParameterizationQuadEdgeMeshFilter.h:  using OutputCoordRepType = typename OutputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkParameterizationQuadEdgeMeshFilter.hxx:        InputCoordRepType const value = (*m_CoefficientsMethod)(input, temp);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkParameterizationQuadEdgeMeshFilter.hxx:          InputCoordRepType const value = (*m_CoefficientsMethod)(input, temp);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  virtual InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const oValue = 1.0 / pt1.EuclideanDistanceTo(pt2);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType oValue(0.0);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    return std::max(InputCoordRepType{}, oValue);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType oValue{};
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType m_Lambda;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  IntrinsicMatrixCoefficients(const InputCoordRepType & iLambda)
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType oValue = m_Lambda * conformal(iMesh, iEdge) + (1.0 - m_Lambda) * authalic(iMesh, iEdge);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  using InputCoordRepType = typename InputMeshType::CoordinateType;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:  InputCoordRepType
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const L1A = v1A * v1A;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const L1B = v1B * v1B;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const L12 = v12 * v12;
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const L2A = pt2.SquaredEuclideanDistanceTo(ptA);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const L2B = pt2.SquaredEuclideanDistanceTo(ptB);
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const AreaA = 0.5 * (cross(v1A, v12).GetNorm());
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const AreaB = 0.5 * (cross(v1B, v12).GetNorm());
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshParamMatrixCoefficients.h:    InputCoordRepType const oValue = (L1A + L2A - L12) / AreaA + (L1B + L2B - L12) / AreaB;
Modules/Filtering/QuadEdgeMeshFiltering/test/itkCleanQuadEdgeMeshFilterTest.cxx:  typename CleanFilterType::InputCoordRepType const absTol{};
Modules/Filtering/QuadEdgeMeshFiltering/test/itkLaplacianDeformationQuadEdgeMeshFilterWithSoftConstraintsTest.cxx:  typename FilterType::OutputCoordRepType const lambda = 1.0;
Modules/IO/MeshBase/include/itkMeshFileReader.h:  using OutputCoordRepType = typename OutputMeshType::CoordinateType;
Modules/Nonunit/Review/include/itkMultiphaseFiniteDifferenceImageFilter.h:  using InputCoordRepType = typename InputPointType::CoordinateType;
Modules/Registration/FEM/include/itkFEMRegistrationFilter.hxx:  using WarperCoordRepType = typename WarperType::CoordinateType;
Modules/Registration/FEM/include/itkFEMRegistrationFilter.hxx:  using InterpolatorType1 = itk::LinearInterpolateImageFunction<MovingImageType, WarperCoordRepType>;
Modules/Registration/FEM/include/itkFEMRegistrationFilter.hxx:  using WarperCoordRepType = typename WarperType::CoordinateType;
Modules/Registration/FEM/include/itkFEMRegistrationFilter.hxx:  using InterpolatorType1 = itk::LinearInterpolateImageFunction<MovingImageType, WarperCoordRepType>;
Modules/Registration/FEM/include/itkFEMRegistrationFilter.hxx:        inputIndex[jj] = (WarperCoordRepType)index[jj];

@N-Dekker N-Dekker changed the title Add ITK_FUTURE_DEPRECATED macro, use it in itkSingleton.h Add ITK_FUTURE_DEPRECATED macro, use it in itkSingleton.h and for CoordRepType Dec 2, 2024
@hjmjohnson hjmjohnson merged commit 93b1e4f into InsightSoftwareConsortium:master Dec 2, 2024
17 checks passed
@N-Dekker N-Dekker mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowekamp blowekamp blowekamp left review comments

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@N-Dekker @hjmjohnson @blowekamp @dzenanz