Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize initialization of local SmartPointer variables #4964

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Modernize initialization of local SmartPointer variables #4964

merged 2 commits into from
Nov 20, 2024

Conversation

N-Dekker
Copy link
Contributor

Two style commits:

@N-Dekker
STYLE: Replace Pointer var; var = x with Pointer var = x
642fb7f 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([^ ][^=\r\n]*::Pointer)([ ]+)(\w+);[\r\n]+\1\4\ =
    Replace with: $1$2$3$4 =
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

- Follow-up to pull request InsightSoftwareConsortium#4952
commit b4b8e7b
@N-Dekker
STYLE: Replace T::Pointer with auto when initializing variables by New()
6e65638 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)(typename )?([^ ].+)::Pointer[ ]+(\w+[ ]+= \3::New\(\);)
    Find what: ^( [ ]+)(typename )?([^ ].+)::Pointer[ ]+(\w+[ ]+=\r\n\1  \3::New\(\);)
    Replace with: $1auto $4
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

Manually excluded the initialization of `m_ConvolutionImageFilter` (in
"itkFFTDiscreteGaussianImageFilter.h") as it is not a local variable.

Follow-up to pull request InsightSoftwareConsortium#2826
commit 5ab79bc
"STYLE: Use `auto` for declaration of variables initialized by `New()`"
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Numerics Issues affecting the Numerics module labels Nov 20, 2024
@blowekamp
Copy link
Member

Did you include the Examples directory with these changes?

@N-Dekker
Copy link
Contributor Author

Did you include the Examples directory with these changes?

No, I only included files from "ITK/Modules", thanks for reminding me, Bradley! Would be nice for a follow-up!

(I'd rather not include them with this PR, as it is already quite large: over 100 code changes.)

@N-Dekker
Copy link
Contributor Author

N-Dekker commented Nov 20, 2024 •
edited
Loading

/azp run ITK.macOS.Python

@N-Dekker N-Dekker marked this pull request as ready for review November 20, 2024 16:10
@N-Dekker N-Dekker mentioned this pull request Nov 20, 2024
Merged
7 tasks
@hjmjohnson hjmjohnson merged commit 677b761 into InsightSoftwareConsortium:master Nov 20, 2024
17 checks passed
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 20, 2024
@N-Dekker
STYLE: Replace Iterator it; it = x with iterator it = x
492f777 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([^ ][^=\r\n]*[Ii]terator[^=\r\n]*)([ ]+)(\w+[Ii]t);[\r\n]+\1\4\ =
    Replace with: $1$2$3$4 =
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

- Follow-up to pull request InsightSoftwareConsortium#4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 20, 2024
@N-Dekker
STYLE: Replace Iterator it; it = x with Iterator it = x
ce1e3cf 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([^ ][^=\r\n]*[Ii]terator[^=\r\n]*)([ ]+)(\w+[Ii]t);[\r\n]+\1\4\ =
    Replace with: $1$2$3$4 =
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

- Follow-up to pull request InsightSoftwareConsortium#4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"
@N-Dekker N-Dekker mentioned this pull request Nov 21, 2024
Merged
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 21, 2024
@N-Dekker
STYLE: Replace Pointer var; var = x with Pointer var = x in Examples
e6bc01e 
- Follow-up to pull request InsightSoftwareConsortium#4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"

Triggered by a comment by Bradley Lowekamp at
InsightSoftwareConsortium#4964 (comment)
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 21, 2024
@N-Dekker
STYLE: Replace T::Pointer with auto when initializing by New in Examples
b03776a 
- Follow-up to pull request InsightSoftwareConsortium#4964
commit 677b761
"STYLE: Replace T::Pointer with auto when initializing variables by New()"

Triggered by a comment by Bradley Lowekamp at
InsightSoftwareConsortium#4964 (comment)
@N-Dekker N-Dekker mentioned this pull request Nov 21, 2024
Merged
hjmjohnson pushed a commit that referenced this pull request Nov 21, 2024
@N-Dekker @hjmjohnson
STYLE: Replace Pointer var; var = x with Pointer var = x in Examples
c413668 
- Follow-up to pull request #4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"

Triggered by a comment by Bradley Lowekamp at
#4964 (comment)
hjmjohnson pushed a commit that referenced this pull request Nov 21, 2024
@N-Dekker @hjmjohnson
STYLE: Replace T::Pointer with auto when initializing by New in Examples
26b0378 
- Follow-up to pull request #4964
commit 677b761
"STYLE: Replace T::Pointer with auto when initializing variables by New()"

Triggered by a comment by Bradley Lowekamp at
#4964 (comment)
hjmjohnson pushed a commit that referenced this pull request Nov 21, 2024
@N-Dekker @hjmjohnson
STYLE: Replace Iterator it; it = x with Iterator it = x
89b5bd0 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([^ ][^=\r\n]*[Ii]terator[^=\r\n]*)([ ]+)(\w+[Ii]t);[\r\n]+\1\4\ =
    Replace with: $1$2$3$4 =
    Filters: itk*.* !+\test
    Directory: D:\src\ITK\Modules
    [v] Match case
    (*) Regular expression

- Follow-up to pull request #4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Nov 22, 2024
@N-Dekker
STYLE: Replace T::Pointer with auto when initializing variables by New()
74c17c7 
- Following ITK pull request InsightSoftwareConsortium/ITK#4964 commit InsightSoftwareConsortium/ITK@677b761
@N-Dekker N-Dekker mentioned this pull request Nov 23, 2024
Merged
N-Dekker added a commit to SuperElastix/elastix that referenced this pull request Nov 23, 2024
@N-Dekker
STYLE: Replace T::Pointer with auto when initializing variables by New()
4e22843 
- Following ITK pull request InsightSoftwareConsortium/ITK#4964 commit InsightSoftwareConsortium/ITK@677b761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@N-Dekker @blowekamp @hjmjohnson @dzenanz