Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Remove features that were deprecated in ITKv5 #4729

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ENH: Remove features that were deprecated in ITKv5 #4729

merged 1 commit into from
Jun 21, 2024

Conversation

hjmjohnson
Copy link
Member

Deprecated capabilities of ITKv5 are now removed
in ITKv6.

Deprecated API's removed.

PR Checklist

@hjmjohnson hjmjohnson self-assigned this Jun 19, 2024
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jun 19, 2024
thewtex
thewtex requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👍

Thanks, @hjmjohnson !

Please add an entry in the Migration Guide.

dzenanz
dzenanz reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A short entry in migration guide should suffice. E.g.:

All contents of the Deprecated module were removed. This includes TreeContainer and related classes; atomic primitives, mutexes and related classes which are now part of C++ standard; specialized Vector filters - specialized versions are no longer needed, as regular filters can work with vector images. For details, see https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/docs/migration_guides/itk_5_migration_guide.md

@hjmjohnson hjmjohnson force-pushed the clear-deprecated-code branch from 55d3563 to 4d7cbe4 Compare June 19, 2024 16:52
@github-actions github-actions bot added the area:Documentation Issues affecting the Documentation module label Jun 19, 2024
@dzenanz
Copy link
Member

dzenanz commented Jun 19, 2024

##[error]This is a scheduled macOS-11 brownout. The macOS-11 environment is deprecated and will be removed on June 28th, 2024.

@hjmjohnson
Copy link
Member Author

##[error]This is a scheduled macOS-11 brownout. The macOS-11 environment is deprecated and will be removed on June 28th, 2024.

That error is related to: #4726
which is related to updating the dashboard needed to find the failure.

@hjmjohnson
Copy link
Member Author

/azp run ITK.macOS

@hjmjohnson
Copy link
Member Author

/azp run ITK.macOS.Python

@hjmjohnson hjmjohnson force-pushed the clear-deprecated-code branch from 4d7cbe4 to c5ba0e4 Compare June 20, 2024 13:12
@hjmjohnson
ENH: Remove features that were deprecated in ITKv5
5a3e629 
Deprecated capabilities of ITKv5 are now removed
in ITKv6.
@hjmjohnson hjmjohnson force-pushed the clear-deprecated-code branch from c5ba0e4 to 5a3e629 Compare June 20, 2024 17:51
@hjmjohnson hjmjohnson merged commit 91251de into InsightSoftwareConsortium:master Jun 21, 2024
13 checks passed
@hjmjohnson hjmjohnson deleted the clear-deprecated-code branch June 21, 2024 02:30
@dzenanz dzenanz mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhlegarreta jhlegarreta jhlegarreta left review comments

@dzenanz dzenanz dzenanz approved these changes

@blowekamp blowekamp blowekamp approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees

@hjmjohnson hjmjohnson

Labels
area:Documentation Issues affecting the Documentation module area:Python wrapping Python bindings for a class type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hjmjohnson @dzenanz @thewtex @blowekamp @jhlegarreta