Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cxx 17 features directly #4710

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Use cxx 17 features directly #4710

merged 2 commits into from
Jun 6, 2024

Conversation

hjmjohnson
Copy link
Member

Remove specialized ITK functionality that is now part of the CXX-17 standard language.

PR Checklist

  • [] API changes that are backward compatible if cxx17 language features are used directly
  • No major design changes were made (or the changes have been approved)
  • Updated API documentation (or API not changed) Compiler messages provide instructions for how to update codebase.

@hjmjohnson hjmjohnson added type:Compiler Compiler support or related warnings type:Enhancement Improvement of existing methods or implementation type:Style Style changes: no logic impact (indentation, comments, naming) labels Jun 4, 2024
@hjmjohnson hjmjohnson self-assigned this Jun 4, 2024
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module and removed type:Compiler Compiler support or related warnings type:Enhancement Improvement of existing methods or implementation type:Style Style changes: no logic impact (indentation, comments, naming) labels Jun 4, 2024
@hjmjohnson
Copy link
Member Author

@thewtex FYI: Clang-format is tormenting me again. Is there something I am doing wrong?

@thewtex
Copy link
Member

thewtex commented Jun 5, 2024

@hjmjohnson maybe rebase on master

@hjmjohnson
Copy link
Member Author

@hjmjohnson maybe rebase on master

% git fetch upstream                                                                                                                                                                             
% git rebase upstream/master                                                                                                                                                                     
Current branch use-cxx-17-features-directly is up to date.
% git push
Everything up-to-date

@thewtex
Copy link
Member

thewtex commented Jun 5, 2024

@hjmjohnson follow-up in #4712

@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Jun 5, 2024
@hjmjohnson hjmjohnson force-pushed the use-cxx-17-features-directly branch from 1776bfb to fdfe8c4 Compare June 6, 2024 15:07
@github-actions github-actions bot removed the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Jun 6, 2024
thewtex
thewtex approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hjmjohnson hjmjohnson merged commit e148489 into InsightSoftwareConsortium:master Jun 6, 2024
13 checks passed
@hjmjohnson hjmjohnson deleted the use-cxx-17-features-directly branch June 6, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:Core Issues affecting the Core module type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjmjohnson @thewtex @dzenanz