ENH: Remove Clang Format Linter Action #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This never worked from fork PR pull requests due to GitHub permission limitations. While it may be possible to fix this with recently added GitHub Action permission features, a future replacement is planned based on the `pre-commit` hooks, InsightSoftwareConsortium#4235 and related.
github-actions
bot
added
type:Infrastructure
2 tasks
thewtex
force-pushed
the
rm-clang-format-action
branch
from
b7f5d29 to
4b0d263
Compare
dzenanz
approved these changes
Jun 3, 2024
hjmjohnson
approved these changes
Jun 3, 2024
thewtex
added a commit
to thewtex/ITK
that referenced
this pull request
Jun 5, 2024
The was intended to be removed in InsightSoftwareConsortium#4707. Forgo both in favor of future pre-commit based Actions.
|
We might want to revert this, given #4712. |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Sep 23, 2024
Ran at bash:
find . -regex '.*itk.*\.\(hxx\|h\|cxx\)' -exec /f/bin/ITK/ClangFormat-prefix/src/ClangFormat/clang-format.exe -style=file -i {} \;
Manually reverted changes in ThirdParty.
At the moment, the "client side" is responsible for running clang-format.exe
Related commits:
- pull request InsightSoftwareConsortium#4712
commit c7e8b25
"BUG: Remove Apply clang-format to PR", June 5, 2024
- pull request InsightSoftwareConsortium#4707
commit 4b0d263
"ENH: Remove Clang Format Linter Action", June 3 2024
dzenanz
pushed a commit
that referenced
this pull request
Sep 26, 2024
Ran at bash:
find . -regex '.*itk.*\.\(hxx\|h\|cxx\)' -exec /f/bin/ITK/ClangFormat-prefix/src/ClangFormat/clang-format.exe -style=file -i {} \;
Manually reverted changes in ThirdParty.
At the moment, the "client side" is responsible for running clang-format.exe
Related commits:
- pull request #4712
commit c7e8b25
"BUG: Remove Apply clang-format to PR", June 5, 2024
- pull request #4707
commit 4b0d263
"ENH: Remove Clang Format Linter Action", June 3 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never worked from fork PR pull requests due to GitHub permission
limitations. While it may be possible to fix this with recently added
GitHub Action permission features, a future replacement is planned based
on the
pre-commithooks, #4235 and related.