ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ITK_MACROEND_NOOP_STATEMENT is always supported in compilers, and allows macros to be used with semi-colons without warnings or clang-format inconsistencies.
hjmjohnson
added
the
type:Style
github-actions
bot
added
type:Enhancement
Closed
github-actions
bot
added
type:Infrastructure
dzenanz
approved these changes
Jun 3, 2024
seanm
reviewed
Jun 3, 2024
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 30, 2024
Aims to resolve issue #1224 "Missing semicolons causing compile issues with some compilers". ITK has become stricter with respect to those semicolons from ITK pull request InsightSoftwareConsortium/ITK#4706 commit InsightSoftwareConsortium/ITK@55e2339 "ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT", Hans Johnson, June 4, 2024. Co-authored-by: Wildcarde <[email protected]>
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 30, 2024
Aims to resolve issue #1224 "Missing semicolons causing compile issues with some compilers". ITK has become stricter with respect to those semicolons from ITK pull request InsightSoftwareConsortium/ITK#4706 commit InsightSoftwareConsortium/ITK@55e2339 "ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT", Hans Johnson, June 4, 2024. Co-authored-by: Wildcarde <[email protected]>
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Aug 30, 2024
Aims to resolve issue #1224 "Missing semicolons causing compile issues with some compilers". ITK has become stricter with respect to those semicolons from ITK pull request InsightSoftwareConsortium/ITK#4706 commit InsightSoftwareConsortium/ITK@55e2339 "ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT", Hans Johnson, June 4, 2024. Co-authored-by: Wildcarde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ITK_MACROEND_NOOP_STATEMENT is always supported in compilers,
and allows macros to be used with
semi-colons without warnings or clang-format
inconsistencies.
related to #4699
PR Checklist
NOTE: Does require ';' at the end of ITK macros when used. This greatly simplifies meeting the clang-format desired formatting behaviors in the code base.