Prefer cxx modern names directly #4703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
added
the
type:Style
github-actions
bot
added
type:Infrastructure
dzenanz
reviewed
May 31, 2024
| @@ -36,18 +36,9 @@ | |||
| #include <type_traits> // For conditional and integral_constant. | |||
| #include <utility> // For tuple_element and tuple_size. | |||
|
|
|||
| // Macro added to each `ImageRegion` member function that overrides a virtual member function of `Region`, when legacy | |||
There was a problem hiding this comment.
@N-Dekker did you change legacy level for this recently?
The non-const API variants are no longer supported at compiletime. Replace 'ITKv5_CONST' with 'const'.
ITKv4 compile time API support is removed.
Use initialization rather than assignment in the constructor.
Remove ITK aliases for language features that are no longer optional.
These long-time legacy interfaces are no longer supported in ITKv6.
Remove Macro added to each `ImageRegion` member function that overrides a virtual member function of `Region`, when legacy support is enabled. Without legacy support, `ImageRegion` will no longer inherit from `Region`, so then those `ImageRegion` member functions will no longer override.
hjmjohnson
force-pushed
the
prefer-cxx-modern-names-directly
branch
from
03c1c48 to
02c577c
Compare
|
After reading discussions on #4693 deciding not to pursue this in it's present form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy API's
PR Checklist