-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Gcc13.2 compiler warnings #4637
COMP: Gcc13.2 compiler warnings #4637
Conversation
eda087b
to
3edf0fa
Compare
I ran all 3 files through the clang-format-Darwin binary from the build tree, but there are no changes identified. I don't know how to fix the CI errors that are posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚
@hjmjohnson please rebase for style fixes |
3edf0fa
to
3a0fc51
Compare
/azp ITK.macOS.Arm64 |
3a0fc51
to
5cd6c52
Compare
todo: rebase on #4642 after merged. |
5cd6c52
to
e1c5d05
Compare
Modules/Segmentation/LevelSets/include/itkParallelSparseFieldLevelSetImageFilter.hxx
Outdated
Show resolved
Hide resolved
ITK/Modules/Segmentation/LevelSets/include/itkParallelSparseFieldLevelSetImageFilter.hxx: In member function ‘ThreadedAllocateData’: ITK/Modules/Segmentation/LevelSets/include/itkParallelSparseFieldLevelSetImageFilter.hxx:789:49: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=] 789 | m_Data[ThreadId].m_LoadTransferBufferLayers = new LayerListType[2 * m_NumberOfLayers + 1]; | ^ /usr/include/c++/13/new:128:26: note: in a call to allocation function ‘operator new []’ declared here 128 | _GLIBCXX_NODISCARD void* operator new[](std::size_t) _GLIBCXX_THROW (std::bad_alloc) | ^ ITK/Modules/Segmentation/LevelSets/include/itkParallelSparseFieldLevelSetImageFilter.hxx: In member function ‘ThreadedAllocateData’: ITK/Modules/Segmentation/LevelSets/include/itkParallelSparseFieldLevelSetImageFilter.hxx:789:49: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=] 789 | m_Data[ThreadId].m_LoadTransferBufferLayers = new LayerListType[2 * m_NumberOfLayers + 1]; | ^ /usr/include/c++/13/new:128:26: note: in a call to allocation function ‘operator new []’ declared here 128 | _GLIBCXX_NODISCARD void* operator new[](std::size_t) _GLIBCXX_THROW (std::bad_alloc) |
Limit possible index overflow. In member function ‘SetVnlVector’, inlined from ‘_wrap_itkVectorUC2_SetVnlVector’ at ITK/cmake-build-release/Wrapping/Modules/ITKCommon/itkVectorPython.cpp:31005:0: ITK/Modules/Core/Common/include/itkVector.hxx:160: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 160 | (*this)[i] = v(i); | ITK/Modules/Core/Common/include/itkFixedArray.h: In function ‘_wrap_itkVectorUC2_SetVnlVector’: ITK/Modules/Core/Common/include/itkFixedArray.h:437:10: note: at offset 2 into destination object ‘m_InternalArray’ of size 2 437 | CArray m_InternalArray; | ^
Initialize the memory to zeros upon allocation. Avoid initialization followed by assignment to zero.
e1c5d05
to
e64032a
Compare
/azp ITK.macOS.Arm64 |
@hjmjohnson patch for the Nifti tests here: #4659 |
cdc28b0
into
InsightSoftwareConsortium:master
Fix compiler warnings issues with python building turned on.
PR Checklist