Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix ìtkResmapleImageTest2 test failing on 32-bit systems. #462

Merged
merged 1 commit into from
Feb 2, 2019
Merged

BUG: Fix ìtkResmapleImageTest2 test failing on 32-bit systems. #462

merged 1 commit into from
Feb 2, 2019

Conversation

jhlegarreta
Copy link
Member

Fix ìtkResmapleImageTest2 test failing on 32-bit systems. Fixes:
https://open.cdash.org/testDetails.php?test=728564967&build=5731782

@jhlegarreta jhlegarreta requested a review from thewtex February 2, 2019 06:10
@jhlegarreta jhlegarreta mentioned this pull request Feb 2, 2019
Merged
@jhlegarreta
Copy link
Member Author

Not sure whether this will do the magic. I built ITK with Win32 configuration, and the output image dimensions are still 320.,320. Also, it is weird since the division yields an integer number (256/0.8 = 320), so to be honest, I ignore where the off-by-one error is coming from.

@jhlegarreta jhlegarreta force-pushed the FixItkResampleTest2_32BitMachineFailures branch from 2baac3f to 3ea20af Compare February 2, 2019 16:21
@jhlegarreta
Copy link
Member Author

Using itk::Math::Ceil instead of std::ceil for the sake of consistency, although I guess that will not solve the issue. Also, CDash reported failures for 2baac3f but the dashboard was green.

thewtex
thewtex approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thewtex thewtex merged commit 4f87d1f into InsightSoftwareConsortium:master Feb 2, 2019
@jhlegarreta
Copy link
Member Author

The fix seems to have made the trick: the dashboard is green !
http://testing.cdash.org/index.php?project=Insight

🎉 🎆

@jhlegarreta jhlegarreta deleted the FixItkResampleTest2_32BitMachineFailures branch February 3, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhlegarreta @thewtex