BUG: Fix removal of '-' from patientId #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
added
the
type:Testing
github-actions
bot
added
type:Bug
The use of std::remove was not correctly implemented. After removing '-' from the string and shuffling items forward into the space, the remaining items in the string need to be explicitly erased.
hjmjohnson
force-pushed
the
fix-remove-char-bug
branch
from
a2a5da9 to
b243803
Compare
hjmjohnson
merged commit 085446a
into
InsightSoftwareConsortium:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of std::remove was not correctly implemented. After removing '-' from the string and shuffling items forward into the space, the remaining items
in the string need to be explicitly erased.
PR Checklist