-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed parameter preservation after identity #4485
Merged
hjmjohnson
merged 1 commit into
InsightSoftwareConsortium:master
from
hjmjohnson:fixed-parameter-preservation-after-identity
Mar 17, 2024
+19
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for giving this approach a try, Hans! I think it's the right way to go. As far as I can see, the Scale*Transform tests still pass 👍 (Right? Please check!) Only itkSimilarity2DTransformTest appears to fail, but I think itkSimilarity2DTransformTest itself is wrong! I'll have another look.
I see, itkSimilarity2DTransformTest assumes that
transform->SetIdentity()
also resets the center. If we agree that that assumption should be dropped (the main purpose of your PR), the test should just manually reset the center. Specifically here, around line 159:ITK/Modules/Core/Transform/test/itkSimilarity2DTransformTest.cxx
Lines 158 to 159 in cd49925
The test fails because it tries to do the 15 degrees rotations from the wrong center. It will pass when a
transform->SetCenter({})
is added, either before or aftertransform->SetIdentity()
.Hope that helps!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-Dekker Thanks. I won't be able to spend time digging into this until after next week. I appreciate any assistance I can get.
2877 - itkSimilarity2DTransformTest (Failed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, just adding
transform->SetCenter({})
to line 159 of itkSimilarity2DTransformTest.cxx should make the CI happy.Conceptually, people should no longer assume that
transform->SetIdentity()
"automagically" resets the center. It's a (potentially) breaking change. But I think it's a correct one.