COMP: Locally ignore Clang -Wmismatched-tags warnings in ImageRegion
#4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After pull request InsightSoftwareConsortium#4367 commit 72aa9a6 (ENH: `ImageRegion` support C++17 structured binding), a few unimportant `-Wmismatched-tags` warnings appeared from Mac10.13-AppleClang-rel-x86_64, at https://open.cdash.org/build/9256915 as was reported to me by mail, from Dženan Zukić and Sean McBride. This commit locally disables those warnings, following https://github.com/Naios/continuable/blob/121265df7123cf672ea8db917eaca2d0fbd9aef5/include/continuable/continuable-result.hpp#L291-L308 by Denis Blank.
github-actions
bot
added
type:Compiler
dzenanz
approved these changes
Feb 9, 2024
|
@seanm does this take care of the warnings? |
|
Ah, just saw this now. I suppose it's unnecessary when changing the bots to use But merging it too would be harmless. Up to you. |
Thanks @seanm, but if this PR is entirely unnecessary, I'd rather just abandon it. Could it possibly still be useful to other ITK users? |
I suppose it could. After all, it's ITK itself turning on |
|
/azp run ITK.Windows |
thewtex
approved these changes
Feb 11, 2024
seanm
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pull request #4367 commit 72aa9a6 (ENH:
ImageRegionsupport C++17 structured binding), a few unimportant-Wmismatched-tagswarnings appeared from Mac10.13-AppleClang-rel-x86_64, athttps://open.cdash.org/build/9256915 as was reported to me by mail, from Dženan Zukić (@dzenanz) and Sean McBride (@seanm).
This commit locally disables those warnings, following https://github.com/Naios/continuable/blob/121265df7123cf672ea8db917eaca2d0fbd9aef5/include/continuable/continuable-result.hpp#L291-L308 by Denis Blank (@Naios).