Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples, PyUtils: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro #4382

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Examples, PyUtils: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro #4382

merged 2 commits into from
Jan 2, 2024

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Jan 2, 2024 •
edited
Loading

Follow-up to pull request #4373 commit 2c264ea
"STYLE: Replace itkTypeMacro calls with itkOverrideGetNameOfClassMacro"

Addresses "ITK_FUTURE_LEGACY_REMOVE" compile errors from RogueResearch19/Mac12.x-AppleClang-dbg-Universal at https://open.cdash.org/viewBuildError.php?buildid=9269183 saying:


/Users/builder/externalExamples/Filtering/CompositeFilterExample.cxx:89:3: error: static_assert failed "In a future revision of ITK, the macro `itkTypeMacro(thisClass, superclass)` will be removed. Please call `itkOverrideGetNameOfClassMacro(thisClass)` instead!"
  itkTypeMacro(CompositeExampleImageFilter, ImageToImageFilter);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[CTest: warning matched] /Users/builder/externalModules/Core/Common/include/itkMacro.h:449:5: note: expanded from macro 'itkTypeMacro'
    static_assert(false,                                                                                           \
    ^             ~~~~~
1 error generated.

Reported by @dzenanz at #4367 (comment)

@N-Dekker
COMP: Examples: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro
cfd51ca 
Follow-up to pull request InsightSoftwareConsortium#4373
commit 2c264ea
"STYLE: Replace itkTypeMacro calls with `itkOverrideGetNameOfClassMacro`"
@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Examples Demonstration of the use of classes labels Jan 2, 2024
@N-Dekker
COMP: PyUtils: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro
f0614a3 
Follow-up to pull request InsightSoftwareConsortium#4373
commit 2c264ea
"STYLE: Replace itkTypeMacro calls with `itkOverrideGetNameOfClassMacro`"
@N-Dekker N-Dekker changed the title COMP: Examples: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro Examples, PyUtils: Replace itkTypeMacro with itkOverrideGetNameOfClassMacro Jan 2, 2024
@N-Dekker N-Dekker marked this pull request as ready for review January 2, 2024 16:23
thewtex
thewtex approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hjmjohnson hjmjohnson self-assigned this Jan 2, 2024
@hjmjohnson hjmjohnson merged commit c1af2b7 into InsightSoftwareConsortium:master Jan 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@thewtex thewtex thewtex approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:Examples Demonstration of the use of classes type:Compiler Compiler support or related warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@N-Dekker @thewtex @hjmjohnson @dzenanz