Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Remove unused local ImageRegion variables #4345

Merged
merged 1 commit into from
Nov 28, 2023
Merged

STYLE: Remove unused local ImageRegion variables #4345

merged 1 commit into from
Nov 28, 2023

Conversation

N-Dekker
Copy link
Contributor

Fixed ITK.macOS/Darwin/Xcode_13.2.1/clang-1300.0.29.30 warnings that appear when ImageRegion is made trivially copyable, saying:

warning: unused variable 'region' [-Wunused-variable]

Removed an obsolete type alias from itkResampleImageTest8.cxx, to avoid a warning, saying:

warning: unused type alias 'OutputImageRegionType' [-Wunused-local-typedef]

This is in fact a "spin-off" (by-product) of pull request #4344: The "unused variable" warnings only appeared after making ImageRegion trivially copyable.

@N-Dekker
STYLE: Remove unused local ImageRegion variables
8d3b937 
Fixed ITK.macOS/Darwin/Xcode_13.2.1/clang-1300.0.29.30 warnings that appear when
`ImageRegion` is made trivially copyable, saying:

> warning: unused variable 'region' [-Wunused-variable]

Removed an obsolete type alias from itkResampleImageTest8.cxx, to avoid a
warning, saying:

> warning: unused type alias 'OutputImageRegionType' [-Wunused-local-typedef]
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Nov 24, 2023
@N-Dekker N-Dekker mentioned this pull request Nov 24, 2023
Merged
@N-Dekker N-Dekker marked this pull request as ready for review November 24, 2023 15:40
@N-Dekker
Copy link
Contributor Author

I think this PR is ready, but First interaction / build (pull_request_target) fails, saying:

internal/modules/cjs/loader.js:1032
  throw err;
  ^

Error: Cannot find module 'node:assert'

Any clue what to do? Is it a show stopper?

@dzenanz
Copy link
Member

dzenanz commented Nov 27, 2023

Not a showstopper. Perhaps node needs to be either upgraded or downgraded somewhere?

@dzenanz dzenanz merged commit 1a2e2b3 into InsightSoftwareConsortium:master Nov 28, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

@jhlegarreta jhlegarreta Awaiting requested review from jhlegarreta

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-Dekker @dzenanz