-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Add in-class {}
initializers to classes with override = default
#3917
Merged
dzenanz
merged 1 commit into
InsightSoftwareConsortium:master
from
N-Dekker:in-class-initializers-for-classes-with-override=default
Feb 13, 2023
Merged
STYLE: Add in-class {}
initializers to classes with override = default
#3917
dzenanz
merged 1 commit into
InsightSoftwareConsortium:master
from
N-Dekker:in-class-initializers-for-classes-with-override=default
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in-class `{}` default member initializers to data members of classes that have a destructor declared `override = default`. Follow-up to pull request InsightSoftwareConsortium#3913 commit 5c97b76 "STYLE: Add in-class `{}` initializers to classes with virtual functions"
github-actions
bot
added
area:Core
Issues affecting the Core module
area:Filtering
Issues affecting the Filtering module
area:IO
Issues affecting the IO module
area:Segmentation
Issues affecting the Segmentation module
type:Style
Style changes: no logic impact (indentation, comments, naming)
labels
Feb 8, 2023
Sorry, I had previously overlooked these cases. Obviously my script wasn't yet finished: https://gist.github.com/N-Dekker/738d28b8d7528a32c12e7a129160b00f |
dzenanz
approved these changes
Feb 9, 2023
2 tasks
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 23, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 23, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 25, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 25, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 25, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 25, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 1, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request InsightSoftwareConsortium#3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 4, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request InsightSoftwareConsortium#3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request InsightSoftwareConsortium#3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 6, 2023
The script that was used for the following pull requests: pull request InsightSoftwareConsortium#3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request InsightSoftwareConsortium#3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request InsightSoftwareConsortium#3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request InsightSoftwareConsortium#3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request InsightSoftwareConsortium#3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
dzenanz
pushed a commit
that referenced
this pull request
Mar 20, 2023
The script that was used for the following pull requests: pull request #3851 "STYLE: Add in-class `{}` member initializers to objects created by New()" pull request #3913 "STYLE: Add in-class `{}` initializers to classes with virtual functions" pull request #3917 "STYLE: Add in-class `{}` initializers to classes with override = default" pull request #3941 "STYLE: Add in-class `{}` member initializers to 3-letter data members" pull request #3945 "STYLE: Add in-class `{}` member initializers having trailing comments"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:Core
Issues affecting the Core module
area:Filtering
Issues affecting the Filtering module
area:IO
Issues affecting the IO module
area:Segmentation
Issues affecting the Segmentation module
type:Style
Style changes: no logic impact (indentation, comments, naming)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in-class
{}
default member initializers to data members of classes that have a destructor declaredoverride = default
.Follow-up to pull request #3913 commit 5c97b76
"STYLE: Add in-class
{}
initializers to classes with virtual functions"