Replace postfix with prefix increment and decrement #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
dzenanz
approved these changes
Jul 12, 2022
N-Dekker
force-pushed
the
Replace-postfix-with-prefix
branch
from
2021f7c to
917355e
Compare
dzenanz
approved these changes
Jul 13, 2022
Applied to the root of ITK source tree, at the GNU bash prompt:
find . \( -iname itk*.cxx -or -iname itk*.hxx -or -iname itk*.h \) -exec perl -pi -w -e 's/ (\w+)\+\+;/ ++$1;/g;' {} \;
find . \( -iname itk*.cxx -or -iname itk*.hxx -or -iname itk*.h \) -exec perl -pi -w -e 's/ (\w+)\-\-;/ --$1;/g;' {} \;
Excluded itkConceptChecking.h, as it is intended to check both the prefix *and*
the postfix forms. Excluded the unit tests, as they might intentionally test
the postfix forms.
Follow-up to:
pull request InsightSoftwareConsortium#2493
commit f81578b
"STYLE: Replace postfix by prefix increment in `for` loops in Core/Common"
N-Dekker
force-pushed
the
Replace-postfix-with-prefix
branch
from
917355e to
7cb6454
Compare
hjmjohnson
approved these changes
Jul 14, 2022
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 15, 2022
Applied to the root of elastix source tree, at the GNU bash prompt:
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/ (\w+)\+\+;/ ++$1;/g;' {} \;
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/ (\w+)\-\-;/ --$1;/g;' {} \;
Following ITK pull request InsightSoftwareConsortium/ITK#3484 commit InsightSoftwareConsortium/ITK@ec510c1
In accordance with common C++ guidelines, including:
Google C++ Style Guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics."
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement
Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of ++ and --. Prefer calling the prefix forms"
https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 15, 2022
Applied to the root of elastix source tree, at the GNU bash prompt:
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/ (\w+)\+\+;/ ++$1;/g;' {} \;
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/ (\w+)\-\-;/ --$1;/g;' {} \;
Following ITK pull request InsightSoftwareConsortium/ITK#3484 commit InsightSoftwareConsortium/ITK@ec510c1
In accordance with common C++ guidelines, including:
Google C++ Style Guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics."
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement
Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of ++ and --. Prefer calling the prefix forms"
https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed common C++ guidelines, including:
Google C++ Style Guide: "Use the prefix form (++i) of the increment and
decrement operators unless you need postfix semantics."
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement
Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules,
Guidelines, and Best Practices: "Prefer the canonical form of ++ and --.
Prefer calling the prefix forms"
https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html
Follow-up to pull request #2493 commit f81578b "STYLE: Replace postfix by prefix increment in
forloops in Core/Common"