Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Drop signed and int from some types #3365

Merged
merged 2 commits into from
Apr 8, 2022
Merged

STYLE: Drop signed and int from some types #3365

merged 2 commits into from
Apr 8, 2022

Conversation

Leengit
Copy link
Contributor

@Leengit Leengit commented Apr 6, 2022 •
edited
Loading

STYLE: Drop int from short int, long int, and long long int.
STYLE: Drop signed from signed short, signed int, signed long, and signed long long.

Effected in bash with:

    cd ~/git/ITK
    find * -type f |
      egrep -i -e '\.[it]?(cc|hh|[ch](\+\+|pp?|xx)?)$' |
      fgrep -v ThirdParty |
      xargs sed -i -r \
        -e 's#(^|[^"/A-Za-z_])(long|short) int([^"/A-Za-z_]|$)#\1\2\3#g' \
        -e 's#(^|[^"/A-Za-z_])signed (short|int|long)([^"/A-Za-z_]|$)#\1\2\3#g'

In response to a request by @N-Dekker.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Leengit added 2 commits April 6, 2022 14:49
@Leengit
STYLE: Drop int from long int and short int
e03a941 
cd ~/git/ITK
find * -type f |
  egrep -i -e '\.[it]?(cc|hh|[ch](\+\+|pp?|xx)?)$' |
  fgrep -v ThirdParty |
  xargs sed -i -r -e \
    's#([^"/A-Za-z_]|^)(long|short) int([^"/A-Za-z_]|$)#\1\2\3#g'
@Leengit
STYLE: Drop signed from signed short, signed int, signed long
8c2c654 
cd ~/git/ITK
find * -type f |
  egrep -i -e '\.[it]?(cc|hh|[ch](\+\+|pp?|xx)?)$' |
  fgrep -v ThirdParty |
  xargs sed -i -r -e \
    's#(^|[^"/A-Za-z_])signed (short|int|long)([^"/A-Za-z_]|$)#\1\2\3#g'
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Apr 6, 2022
@Leengit Leengit changed the title STYLE: Drop signed and int from types descriptions STYLE: Drop signed and int from some types Apr 6, 2022
N-Dekker
N-Dekker approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @Leengit ! 👍

@N-Dekker
Copy link
Contributor

N-Dekker commented Apr 7, 2022

Just for the record:

This pull request appears related to pull request #3139 commit a812aa3 "STYLE: Change unsigned to unsigned int.", also by Lee Newberg (This PR may be considered a follow-up).

My request was at #3342 (comment) (regarding pull request "STYLE: Avoid old-style cast")

@thewtex thewtex merged commit ee60c7f into InsightSoftwareConsortium:master Apr 8, 2022
@thewtex thewtex deleted the signed_type_int branch April 8, 2022 13:34
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Apr 8, 2022
@N-Dekker
DOC: Add "Integer Type Specifiers" section
fa8edd8 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Apr 8, 2022
@N-Dekker
DOC: Add "Integer Type Specifiers" section
8ddd3d6 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
@N-Dekker N-Dekker mentioned this pull request Apr 8, 2022
Merged
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Apr 11, 2022
@N-Dekker
DOC: Add "Integer Type Specifiers" section
c000be8 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Apr 13, 2022
@N-Dekker
DOC: Add "Integer Type Specifiers" section
0487224 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Nov 11, 2022
@N-Dekker
DOC: Add "Integer Type Specifiers" section
f0cc03c 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Jan 10, 2023
@N-Dekker
DOC: Add "Integer Type Specifiers" section
a49725e 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Feb 28, 2023
@N-Dekker
DOC: Add "Integer Type Specifiers" section
612adf5 
Added coding style guidelines for specifying built-in integer types and
integer types from the C library.

Following recent ITK commits, authored by Lee Newberg:

pull request InsightSoftwareConsortium/ITK#3365
commit InsightSoftwareConsortium/ITK@8c2c654
commit InsightSoftwareConsortium/ITK@e03a941
"STYLE: Drop `signed` and `int` from some types"

pull request InsightSoftwareConsortium/ITK#3139
commit InsightSoftwareConsortium/ITK@a812aa3
"STYLE: Change unsigned to unsigned int."

pull request InsightSoftwareConsortium/ITK#3250
commit InsightSoftwareConsortium/ITK@c173dfd
"STYLE: Remove `std::` prefix from types that work without it"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@N-Dekker N-Dekker N-Dekker approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leengit @N-Dekker @thewtex @dzenanz