ENH: Add ImageToVideoFilter and accompanying wrappings #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Python wrapping
tbirdso
force-pushed
the
image-to-video
branch
4 times, most recently
from
8de6afb to
5a30133
Compare
|
Working on resolving upstream CI warnings not appearing on my local platform. EDIT: Looks like warnings are resolved. |
aylward
approved these changes
Jul 7, 2021
|
@tbirdso please ping me after you have addressed the existing reviews. That way I have somewhat fresh eyes updated PR. |
tbirdso
force-pushed
the
image-to-video
branch
2 times, most recently
from
835a456 to
e825084
Compare
tbirdso
commented
Jul 7, 2021
|
Maybe `FrameIndex` (`FrameStart`) and `FrameCount` or `FrameSize`
(`FrameDuration`)? `FrameDuration` in particular seems like it should be
`1/framerate` which sounds like it isn't.
…On Thu, Jul 8, 2021 at 9:41 AM Tom Birdsong ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Modules/Video/Core/include/itkImageToVideoFilter.hxx
<#2635 (comment)>
:
> +//
+template <typename TInputImage, typename TOutputVideoStream>
+void
+ImageToVideoFilter<TInputImage, TOutputVideoStream>::GenerateOutputInformation()
+{
+ // Get the input
+ const InputImageType * input = this->GetInput();
+
+ // Get first input frame's largest possible spatial region
+ InputImageRegionType inputRegion = input->GetLargestPossibleRegion();
+
+ // Set temporal frame + duration from user-defined frame axis in input image
+ OutputTemporalRegionType outputTemporalRegion;
+ outputTemporalRegion.SetFrameStart(inputRegion.GetIndex(m_FrameAxis));
+ outputTemporalRegion.SetFrameDuration(inputRegion.GetSize(m_FrameAxis));
+ // TODO set real start and real duration
Good questions! Responding to the second part, TemporalRegion represents
the region for an entire TemporalObject, with FrameStart corresponding to
the first frame index and FrameDuration representing the number of frames
in the region. This may be easiest to see in iteration such as in
itk::VideoStream
<https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Video/Core/include/itkVideoStream.hxx#L242>
.
RealStart and RealDuration are the corollary to physical origin and
spacing, though again I believe Duration here corresponds to the time
interval across the entire region as opposed to the spacing between frames.
This naming is maybe ambiguous especially when coming from the perspective
of how we handle physical spacing in Images. I'll add clarifying comments.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGPH7ALE6BAFGEOPDTJIUDTWWTI5ANCNFSM474X57GQ>
.
--
Brad T. Moore, Ph.D.
Staff R&D Engineer, Medical Computing
Kitware, Inc.
http://www.kitware.com
|
dzenanz
reviewed
Jul 8, 2021
tbirdso
force-pushed
the
image-to-video
branch
2 times, most recently
from
8738fce to
310f561
Compare
dzenanz
approved these changes
Jul 9, 2021
tbirdso
force-pushed
the
image-to-video
branch
3 times, most recently
from
467aa8a to
82e3350
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
itk::ImageToVideoFilterto ITKVideoCore module along with baseline test and wrappings.This class serves as a bridge to convert static
itk::Imageobjects toitk::VideoStreamrepresentation. The user supplies anitk::Imageinput to the filter and designates a single axis to interpret as a temporal axis in the output. WhenUpdate()is called the filter allocates the outputitk::VideoStreamand grafts slices of the input along its designated axis onto output frames.The goal of adding this filter is to make it easier to use static data sets as test sets for real-time systems making use of
itk::VideoStreamfor data collection and representation. The filter is single-threaded and could be revisited to take advantage of multithreading from the baseitk::VideoSourceclass at some point in the future.Comments and revisions are welcomed.
@thewtex
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.