STYLE: Replace postfix by prefix increment in for loops in ITK/Modules
#2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied to ITK/Modules, at the GNU bash prompt:
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/(\s+for \(.*; .+); (\w+)\+\+\)/$1; ++$2)/g;' {} \;
(Excluded ITK/Modules/ThirdParty.)
According to Herb Sutter, Andrei Alexandrescu - C++ Coding Standards:
101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of
++ and --. Prefer calling the prefix forms"
Follow-up to:
pull request InsightSoftwareConsortium#2493
commit f81578b
"STYLE: Replace postfix by prefix increment in `for` loops in Core/Common"
|
Nice video by Fred Overflow (@fredoverflow) on this topic: Why C++ programmers prefer ++i over i++ (prefix vs. postfix increment operator, for loop, iterators) --> www.youtube.com/watch?v=bONciSOJ_N4 |
dzenanz
approved these changes
Apr 21, 2021
|
MacCI is working again. 😄 |
I'm glad to hear so @dzenanz I guess MacCI has been waiting for us to fix those postfix increments 😸 |
|
No, it was fixed by #2492, but this is the first PR created since it was merged. I am glad the fix was simple 😄 |
dpshamonin
approved these changes
Apr 22, 2021
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Apr 23, 2021
Applied to the root of ITK, at the GNU bash prompt:
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/(\s+for \(.*;.*); (\w+)\+\+\)/$1; ++$2)/g;' {} \;
(Excluded ITK/Modules/ThirdParty.)
Follow-up to:
pull request InsightSoftwareConsortium#2499
commit 971aef2
"STYLE: Replace postfix by prefix increment in for loops in ITK/Modules"
hjmjohnson
pushed a commit
that referenced
this pull request
Apr 23, 2021
Applied to the root of ITK, at the GNU bash prompt:
find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/(\s+for \(.*;.*); (\w+)\+\+\)/$1; ++$2)/g;' {} \;
(Excluded ITK/Modules/ThirdParty.)
Follow-up to:
pull request #2499
commit 971aef2
"STYLE: Replace postfix by prefix increment in for loops in ITK/Modules"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 20, 2021
Follows common C++ guidelines, including: Google C++ Style Guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics." https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of ++ and --. Prefer calling the prefix forms" https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html Anticipates "[clang-tidy] Add performance-prefer-preincrement check": https://reviews.llvm.org/D72553 Corresponding ITK pull requests, which were merged in April 2021: - InsightSoftwareConsortium/ITK#2505 - InsightSoftwareConsortium/ITK#2499 - InsightSoftwareConsortium/ITK#2493
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 20, 2021
Applied to the root of elastix source tree, at the GNU bash prompt:
$ find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/(\s+for \(.*;.*); (\w+)\+\+\)/$1; ++$2)/g;' {} \;
Follows common C++ guidelines, including:
Google C++ Style Guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics."
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement
Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of ++ and --. Prefer calling the prefix forms"
https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html
Anticipates "[clang-tidy] Add performance-prefer-preincrement check":
https://reviews.llvm.org/D72553
Corresponding ITK pull requests, which were merged in April 2021:
- InsightSoftwareConsortium/ITK#2505
- InsightSoftwareConsortium/ITK#2499
- InsightSoftwareConsortium/ITK#2493
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 21, 2021
Applied to the root of elastix source tree, at the GNU bash prompt:
$ find . \( -iname *.cxx -or -iname *.hxx -or -iname *.h \) -exec perl -pi -w -e 's/(\s+for \(.*;.*); (\w+)\+\+\)/$1; ++$2)/g;' {} \;
Follows common C++ guidelines, including:
Google C++ Style Guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics."
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement
Herb Sutter, Andrei Alexandrescu - C++ Coding Standards: 101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of ++ and --. Prefer calling the prefix forms"
https://www.oreilly.com/library/view/c-coding-standards/0321113586/ch29.html
Anticipates "[clang-tidy] Add performance-prefer-preincrement check":
https://reviews.llvm.org/D72553
Corresponding ITK pull requests, which were merged in April 2021:
- InsightSoftwareConsortium/ITK#2505
- InsightSoftwareConsortium/ITK#2499
- InsightSoftwareConsortium/ITK#2493
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied to ITK/Modules, at the GNU bash prompt:
(Excluded ITK/Modules/ThirdParty.)
According to Herb Sutter, Andrei Alexandrescu - C++ Coding Standards:
101 Rules, Guidelines, and Best Practices: "Prefer the canonical form of
++ and --. Prefer calling the prefix forms"
Follow-up to:
pull request #2493
commit f81578b
"STYLE: Replace postfix by prefix increment in
forloops in Core/Common"