COMP: fix link error building Universal Binary on Intel Mac #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
seanm
force-pushed
the
mac-universal-png
branch
from
33a5add to
f816bdf
Compare
dzenanz
reviewed
Mar 27, 2021
Without this, building Universal Binary on an Intel Mac (but not on an ARM Mac) gives link errors for undefined symbols like _itk_png_do_expand_palette_rgb8_neon and a few others. Introspecting the CPU type of the build machine is fundamentally incompatible with the idea of Universal Binaries.
seanm
force-pushed
the
mac-universal-png
branch
from
f816bdf to
3fe5595
Compare
dzenanz
approved these changes
Mar 27, 2021
|
I created a ticket for upstream libpng too: pnggroup/libpng#372 |
thewtex
approved these changes
Mar 28, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, building Universal Binary on an Intel Mac (but not on an ARM Mac) gives link errors for undefined symbols like _itk_png_do_expand_palette_rgb8_neon and a few others.
Introspecting the CPU type of the build machine is fundamentally incompatible with the idea of Universal Binaries.