Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency issue for Single definitions #914

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Fix concurrency issue for Single definitions #914

merged 3 commits into from
Oct 8, 2020

Commits on Oct 8, 2020

  1. Reproduces the concurrency issue with a test

    @Sloy
    Sloy committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d917df7 View commit details
    Browse the repository at this point in the history

  2. Fix issue by making SingleInstanceFactory.get() thread-safe

    @Sloy
    Sloy committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d33d6d3 View commit details
    Browse the repository at this point in the history

  3. Remove synchronized from create

    @Sloy
    Sloy committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    7fb9129 View commit details
    Browse the repository at this point in the history