Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6.0 compose viewmodel - KMP #1875

Merged
merged 8 commits into from
May 17, 2024
Merged

3.6.0 compose viewmodel - KMP #1875

merged 8 commits into from
May 17, 2024

Conversation

arnaudgiuliani
Copy link
Member

@arnaudgiuliani arnaudgiuliani commented May 15, 2024 •
edited
Loading

  • update latest compose 1.6.10
  • lib deps with compose-viewmodel and navigation
  • port of ViewModel API
  • port of NavViewModel API

keep all @KoinExperimentalAPI for now

Fixing #1826

@arnaudgiuliani arnaudgiuliani mentioned this pull request May 15, 2024
Closed
@arnaudgiuliani arnaudgiuliani self-assigned this May 15, 2024
@arnaudgiuliani
Copy link
Member Author

iOS regression found due to JetBrains/compose-multiplatform#4809

Dev is on hold then :/

@arnaudgiuliani
Copy link
Member Author

arnaudgiuliani commented May 17, 2024 •
edited
Loading

Should be good. Added fix with last compose 1.6.10 rc03
Ported also viewModel and viewModelOf DSL to let define it in common code side.
See https://github.com/arnaudgiuliani/JetpackViewModel-CMP/blob/master/composeApp/src/commonMain/kotlin/AppModule.kt#L7

@arnaudgiuliani arnaudgiuliani merged commit dc6f348 into 3.6.0 May 17, 2024
8 checks passed
@arnaudgiuliani arnaudgiuliani added this to the compose-3.6.0 milestone May 17, 2024
@arnaudgiuliani arnaudgiuliani deleted the 3.6.0_compose_viewmodel branch July 3, 2024 15:41
@renovate renovate bot mentioned this pull request Sep 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arnaudgiuliani arnaudgiuliani

Labels
None yet
Projects
None yet
Milestone
compose-3.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@arnaudgiuliani