Memory leak with sharedViewModel and parameter

[rubengees]

Koin version: 1.0.0-RC-2

I experience a memory leak reported by LeakCanary when using sharedViewModel with a parameter.

I have a ViewModel like this:

class MainViewModel(private val someParameter: String) : ViewModel() {

    fun hello() {
    }
}

and inject it like this in my Fragment:

private val parameter = "hello"
private val viewModel by sharedViewModel<MainViewModel> { parametersOf(parameter) }

My module description is this:

val mainModules = module {
    viewModel { (someParameter: String) -> MainViewModel(someParameter) }
}

LeakCanary shows me this leak (hprof):

Here is a minimal Android project for reproduction. Just install the debug variant, open and close the app; the leak will show up.

If you need anything else, please ask.
Thanks for this great library and looking into this!

[arnaudgiuliani]

Hello,

just ran your code but didn't trigger any memory leak :/ (Pixel 2, Nexus 5X)
had a background crash on setContent from Activity.

[arnaudgiuliani]

(used API 25 & 27)

[rubengees]

Hmm, I just tried it again with an API 25 emulator.
I checked out the repository, ran ./gradlew runDebug and closed the app.
The leak(s) did show up...

[arnaudgiuliani]

Got it.

[arnaudgiuliani]

Try with RC-3

[rubengees]

Works perfectly, thanks!