androidContext() swallows/hides underlying exceptions

[yogurtearl]

If the get() for a context throws an exception, the cause is discarded.
(same applies for Scope.androidApplication())

The e here is discarded.

See this code:

koin/projects/android/koin-android/src/main/java/org/koin/android/ext/koin/ModuleExt.kt

Lines 30 to 34 in 5fab1ca

	fun Scope.androidContext(): Context = try {
	get()
	} catch (e: Exception) {
	throw MissingAndroidContextException("Can't resolve Context instance. $ERROR_MSG")
	}

Instead it should be something like this:

class MissingAndroidContextException(message: String, cause: kotlin.Throwable?)
     : kotlin.Exception(message, cause)

fun Scope.androidContext(): Context = try {
    get()
} catch (e: Exception) {
    throw MissingAndroidContextException("Can't resolve Context instance. $ERROR_MSG", e)
}

[arnaudgiuliani]

Thanks