Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koin 3.5.4 and onwards is no longer Java 1.8 compatible #1887

Closed
antonurankar-moloco opened this issue May 29, 2024 · 3 comments
Closed

Koin 3.5.4 and onwards is no longer Java 1.8 compatible #1887

antonurankar-moloco opened this issue May 29, 2024 · 3 comments
Milestone

Comments

@antonurankar-moloco
Copy link

antonurankar-moloco commented May 29, 2024

Describe the bug

With the release of Koin 3.5.4, its transitive dependency stately has been upgraded to version 2.0.6, which is no longer Java 1.8 compatible.

 Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Failed to transform stately-concurrent-collections-jvm-2.0.6.jar (co.touchlab:stately-concurrent-collections-jvm:2.0.6) to match attributes {artifactType=android-java-res, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
      > Execution failed for JetifyTransform: /Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-concurrent-collections-jvm/2.0.6/fb80df9c69dd0e154c346ee5510601e2d148e23d/stately-concurrent-collections-jvm-2.0.6.jar.
         > Failed to transform '/Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-concurrent-collections-jvm/2.0.6/fb80df9c69dd0e154c346ee5510601e2d148e23d/stately-concurrent-collections-jvm-2.0.6.jar' using Jetifier. Reason: IllegalArgumentException, message: Unsupported class file major version 61. (Run with --stacktrace for more details.)
           Suggestions:
            - Check out existing issues at https://issuetracker.google.com/issues?q=componentid:460323&s=modified_time:desc, it's possible that this issue has already been filed there.
            - If this issue has not been filed, please report it at https://issuetracker.google.com/issues/new?component=460323 (run with --stacktrace and provide a stack trace if possible).
   > Failed to transform stately-concurrency-jvm-2.0.6.jar (co.touchlab:stately-concurrency-jvm:2.0.6) to match attributes {artifactType=android-java-res, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
      > Execution failed for JetifyTransform: /Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-concurrency-jvm/2.0.6/14dcbce3fc3d80a5a07f9df33dd2dc54e437e8d0/stately-concurrency-jvm-2.0.6.jar.
         > Failed to transform '/Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-concurrency-jvm/2.0.6/14dcbce3fc3d80a5a07f9df33dd2dc54e437e8d0/stately-concurrency-jvm-2.0.6.jar' using Jetifier. Reason: IllegalArgumentException, message: Unsupported class file major version 61. (Run with --stacktrace for more details.)
           Suggestions:
            - Check out existing issues at https://issuetracker.google.com/issues?q=componentid:460323&s=modified_time:desc, it's possible that this issue has already been filed there.
            - If this issue has not been filed, please report it at https://issuetracker.google.com/issues/new?component=460323 (run with --stacktrace and provide a stack trace if possible).
   > Failed to transform stately-strict-jvm-2.0.6.jar (co.touchlab:stately-strict-jvm:2.0.6) to match attributes {artifactType=android-java-res, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
      > Execution failed for JetifyTransform: /Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-strict-jvm/2.0.6/fdbcb1fc1c9219aa5a5f2b1c9084a4ed8b2a8f8b/stately-strict-jvm-2.0.6.jar.
         > Failed to transform '/Users/tomi/.gradle_console/caches/modules-2/files-2.1/co.touchlab/stately-strict-jvm/2.0.6/fdbcb1fc1c9219aa5a5f2b1c9084a4ed8b2a8f8b/stately-strict-jvm-2.0.6.jar' using Jetifier. Reason: IllegalArgumentException, message: Unsupported class file major version 61. (Run with --stacktrace for more details.)
           Suggestions:
            - Check out existing issues at https://issuetracker.google.com/issues?q=componentid:460323&s=modified_time:desc, it's possible that this issue has already been filed there.
            - If this issue has not been filed, please report it at https://issuetracker.google.com/issues/new?component=460323 (run with --stacktrace and provide a stack trace if possible).

To Reproduce

Compile Koin 3.5.4+ with Gradle version 6.x and build will fail with error: Unsupported class file major version 61

Expected behavior

Koin should still support Java 1.8. Otherwise mention in the documentation that the support has been dropped.

Koin module and version:
koin-core:3.5.4+
koin-android:3.5.4+

@arnaudgiuliani
Copy link
Member

Contacting touchlab team 👍

@faogustavo
Copy link

Hey folks, we've released version 2.1.0 for Stately, which includes this fix. Please let us know if the problem persists.

Thanks :)

@arnaudgiuliani arnaudgiuliani added this to the 4.0-RC3 milestone Sep 9, 2024
@arnaudgiuliani
Copy link
Member

Hey @faogustavo, thanks for the update 👍

@arnaudgiuliani arnaudgiuliani added the status:accepted accepted to be developed label Sep 9, 2024
arnaudgiuliani added a commit that referenced this issue Sep 9, 2024
arnaudgiuliani added a commit that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants