Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stately-common transitive dependency causing issues with other dependencies #1785

Closed
kpgalligan opened this issue Feb 15, 2024 · 1 comment
Closed

Comments

@kpgalligan
Copy link
Contributor

Describe the bug
See sqldelight bug for details.

To Reproduce
See sqldelight bug for details.

Expected behavior
It doesn't do the thing described in the sqldelight bug.

Koin module and version:
Kotlin/Native targets, latest version(s)

Snippet or Sample project to help reproduce
I'm going to submit a PR. This is a tracking issue.

@arnaudgiuliani
Copy link
Member

Thx 👍

nicolas-f added a commit to Universite-Gustave-Eiffel/NoiseCaptureClient that referenced this issue Jul 16, 2024
Feature/build ios
# Description

Make app compile and run on iOS (setup for simulator only for now, shared setup for physical devices will require a paid Apple Account)

## Changes

- Bumped Koin version to 3.5.6 to solve [this issue](InsertKoinIO/koin#1785)
- Bumped Appyx to 2.0.1 fix [iOS related issues](bumble-tech/appyx#670)
- Bumped cocoapods to latest version
- Use "native" resources management using compose instead of third party library:
  - Updated `compose-plugin` version to `1.6.11` (latest atm)
  - Use the new [default resources management solution](https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-images-resources.html) instead of third party library
  - Updated directory structure and `SpectrumChannelTest::testSpeak` to match this new approach
- Re-enabled iOS github workflow
  - Run shared test suite on iOS simulator
  - Added reports upload for other platforms as well
  - Use `upload-artifact@v4` instead of v3

## Linked issues

- #16 

## Remaining TODOs

- Fix UI issues on iOS devices (currently navigation is not properly offseted on notched devices (iPhone X and above))
  - If we get rid off Appyx, maybe we should keep this for a later PR
- Fix permissions screen (currently the app crashes when user clicks Next)
  - Same as above, can be solved in a later PR
- Add setup instructions, should also be done for other platforms so perhaps we can group it all in a setup.md PR 

## Checklist

- [x] Code compiles correctly on all platforms
- [x] All pre-existing tests are passing
- [x] If needed, new tests have been added
- [x] Extended the README / documentation if necessary
- [x] Added code has been documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants