-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online documentation links are broken #1767
Comments
Hi @NinoDLC, no link is broken there though |
I guess I must be clicking stuff incorrectly then 😁 |
Important I got it @NinoDLC, but it seems like someway it's correct and returning the expected page, and in another way it returns 404 Check these videos 200 oK Koin-Koin.mp4404 not Found Koin-Koin_four-o-four.mp4 |
did you tried refreshing this setup page? Seems all link got to tutorials section. Perhaps a cache problem? 🤔 |
Yes @arnaudgiuliani, I refreshed the setup page several times; and also, it's not a cache problem When I take a look at the doc the Clicking on the next link to see, It's 404, even on the GitHub repo, There is no place you can find the page referenced |
Yes, even refreshing, using a different browser (Firefox),using incognito mode... same issue. |
Go on But agree, there is something wrong in the lings 🤔 |
Please @arnaudgiuliani, where are located the tutorial markdown files ? |
it's located here: https://github.com/InsertKoinIO/koin-getting-started/tree/main/docs |
Alright, I see; this means it's called from another repo.
title: KoinAll you need to setup Koin in your project Current VersionsYou can find all Koin packages on maven central. Here are the currently available versions: Gradle SetupKotlinStarting from 3.5.0 you can use BOM-version to manage all Koin library versions. When using the BOM in your app, you don't need to add any version to the Koin library dependencies themselves. When you update the BOM version, all the libraries that you're using are automatically updated to their new versions. Add implementation(platform("io.insert-koin:koin-bom:$koin_version"))
implementation("io.insert-koin:koin-core") If you are using version catalogs: [versions]
koin-bom = "x.x.x"
...
[libraries]
koin-bom = { module = "io.insert-koin:koin-bom", version.ref = "di-koin" }
koin-core = { module = "io.insert-koin:koin-core" }
... dependencies {
implementation(libs.koin.bom)
implementation(libs.koin.core)
} Or use an old way of specifying the exact dependency version for Koin: dependencies {
implementation("io.insert-koin:koin-core:$koin_version")
} You are now ready to start Koin: fun main() {
startKoin {
modules(...)
}
} If you need testing capacity: dependencies {
// Koin Test features
testImplementation("io.insert-koin:koin-test:$koin_version")
// Koin for JUnit 4
testImplementation("io.insert-koin:koin-test-junit4:$koin_version")
// Koin for JUnit 5
testImplementation("io.insert-koin:koin-test-junit5:$koin_version")
} :::info Android |
fix #1767 - Fix documentation links
Describe the bug
Online documentation links are broken
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Not a 404
The text was updated successfully, but these errors were encountered: