-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storybook #854
feat: add storybook #854
Conversation
Thank you for the PR! Please fix this it's an actual bug, not a matter of coding style and consistency. A render function (a function that returns a JSX Element) isn't equivelent to a react component. Please fix the build as well. Next time be sure to only tag me for review when everything is green. Looking good non the less. |
Quality Gate passedIssues Measures |
This is not really a bug as you can see here : storybookjs/storybook#21115 By the way the hooks is not really necessary so I removed. |
It's a bug. This for example works as expected. We're not breaking any rule: This on the other end dosen't: No asumption can be made on how the In the case of storybook, they are just discussing a way to make ESLint happy without addressing the root cause of the issue. |
No description provided.