Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor English typo fix #608

Closed
wants to merge 2 commits into from
Closed

Minor English typo fix #608

wants to merge 2 commits into from

Conversation

qgau
Copy link
Contributor

@qgau qgau commented Oct 2, 2023

No description provided.

@odysseu
Copy link
Contributor

odysseu commented Oct 3, 2023

I disagree on translation;
It is a catalog of multiple services

@qgau
Copy link
Contributor Author

qgau commented Oct 4, 2023

Hello,

Thank you for your feedbacks.

I believe we are talking about attributives nouns here.
Because here, precisely as you said, "services", plurial, just means several services, and not a specific and different meaning, "service catalog" should be used to describe a catalog of services.

More resources and examples:

That being said, English is not my native language, so I would follow an Expert point of view.
That is your call, and this PR is just a proposal ;-)

Cheers!

@mmwinther
Copy link
Contributor

@qgau is correct, it should be "service catalog" (I'm a native English speaker)

@garronej
Copy link
Contributor

Sorry, there was a big refactoring going on so I couldn't merge but I applyed the fix manually.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants