Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign home jo #171

Merged
merged 14 commits into from
Oct 5, 2020
Merged

Redesign home jo #171

merged 14 commits into from
Oct 5, 2020

Conversation

garronej
Copy link
Contributor

@garronej garronej commented Oct 4, 2020

  • I implemented Mark's design for the home page. figma
  • I renamed acceuil to home.
  • I got rid of Suspense in favour of a more traditional approach for loading async data in react component. ( Suspence is cool but not a stable feature yet)
  • I used YAML instead of JSON to populate the page. Once merged the following env should be edited REACT_APP_HOMEPAGE_URL=https://git.lab.sspcloud.fr/innovation/plateforme-onyxia/services-ressources/-/raw/master/pages-content/home.yaml
  • I encourage everyone to use YAML to JSON when working on pages that are populated from an external resource file. It generates types definitions from a YAML (or JSON) files. It enable to spot typos and inconsistencies in the data structure early on.
  • The page is somehow responsive, see result here

Unfortunately it was not possible to use material UI and respect Mark's design at the same time so I had to write custom CSS.

Of course feel free to change the wording by editing home.yaml especially for the third section that wasn't discussed in details.

Sorry for the large commit's Diff.

Regads

olevitt and others added 10 commits October 1, 2020 14:02
* resize innovation image

* update background-color and remove margins

* use a background image instead of an image element

* use a transparent background for bienvenue Paper component

* tweak button

* typos

* update header and implement cards layout

Co-authored-by: Romain Lesur <[email protected]>
@olevitt
Copy link
Contributor

olevitt commented Oct 5, 2020

LGTM, thx 👍

@garronej
Copy link
Contributor Author

garronej commented Oct 5, 2020

@olevitt @fcomte C'est bon vous pouvez merger hein.

@olevitt olevitt merged commit 1009b6d into master Oct 5, 2020
@olevitt olevitt deleted the redesign-home-jo branch October 5, 2020 12:00
garronej added a commit that referenced this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants