Further options for filtering catalog services

[mmwinther]

Functionality implemented

Supports filtering services based on Helm chart attributes:

• keywords which must be present
• keywords which cannot be present
• annotations which must be present
• annotations which cannot be present

Limitations

Currently can't include multiple values of the same annotation key (e.g. both lifecycle: production, lifecycle: experimental) since the values are supplied in a map and the keys would be duplicated. This could be improved in the future.

Commit summary

• Move includeKeywords check to be a method on Chart
• Filter services based on excluded keywords
• Failing test for includeAnnotations
• Implement filtering on includeAnnotations
• Implement filtering on excludeAnnotations

[olevitt]

Minor comment on the pattern used in your list getters. What do you think ?

[olevitt]

I'm not a huge fan of this pattern of returning different references. In some cases it may leads to odd bugs if the caller then adds items to the returned list for example.
In one case the item would be added to the "real" list but if the list is null then the item would be added to a transient list and will not show up in a next get call.
Wouldn't it suffise to have default empty lists for each variable ? IIRC all objectmappers / json / yaml deserializers has been configured to set an empty list and not a null list so we should be safe

[mmwinther]

@olevitt Yes I agree, good point, I'll make that change 👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[olevitt]

Thank you ! 👍