Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 #288

Merged
merged 5 commits into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
- name: Set up JDK 21
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
java-version: 21
- name: Set current version
run: mvn -B versions:set -DnewVersion=${GITHUB_REF##*/} -DprocessAllModules -DgenerateBackupPoms=false
- name: Build with Maven
Expand All @@ -37,11 +37,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
- name: Set up JDK 21
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
java-version: 21
- name: Check Spotless CodingStyle
run: mvn spotless:check
docker:
Expand Down
2 changes: 1 addition & 1 deletion helm-wrapper/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<description>Simple wrapper for Helm (https://helm.sh)</description>

<properties>
<java.version>17</java.version>
<java.version>21</java.version>
</properties>

<distributionManagement>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ public HelmInstaller installChart(
Map<String, String> env,
final boolean skipTlsVerify,
String caFile)
throws InvalidExitValueException, IOException, InterruptedException, TimeoutException,
throws InvalidExitValueException,
IOException,
InterruptedException,
TimeoutException,
IllegalArgumentException {
StringBuilder command = new StringBuilder("helm upgrade --install ");
if (skipTlsVerify) {
Expand Down Expand Up @@ -96,8 +99,12 @@ public int uninstaller(HelmConfiguration configuration, String name, String name
}

public HelmLs[] listChartInstall(HelmConfiguration configuration, String namespace)
throws JsonMappingException, InvalidExitValueException, JsonProcessingException,
IOException, InterruptedException, TimeoutException {
throws JsonMappingException,
InvalidExitValueException,
JsonProcessingException,
IOException,
InterruptedException,
TimeoutException {
StringBuilder command = new StringBuilder("helm ls");
if (namespace != null) {
command.append(" -n ");
Expand Down
2 changes: 1 addition & 1 deletion onyxia-api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM eclipse-temurin:17.0.8_7-jre
FROM eclipse-temurin:21_35-jre
# Install helm
RUN curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION=v3.12.0 bash
COPY target/*.jar app.jar
Expand Down
4 changes: 2 additions & 2 deletions onyxia-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@
</dependencies>

<properties>
<java.version>17</java.version>
<kotlin.version>1.9.10</kotlin.version>
<java.version>21</java.version>
<kotlin.version>1.9.20-RC</kotlin.version>
</properties>

<build>
Expand Down
4 changes: 2 additions & 2 deletions onyxia-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<version>0.0.1-SNAPSHOT</version>
</parent>
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
</properties>
<dependencies>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public abstract class CatalogWrapper {

@Schema(description = "This entries are those from a standard helm repository")
private Map<String, List<Chart>> entries;

/**
* @return the packages
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,7 @@ public static class Quotas {
private boolean userEnabled = false;
private boolean groupEnabled = false;
private boolean allowUserModification = true;

// could be deprecated
@JsonProperty("default")
private Quota defaultQuota;
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
</distributionManagement>
<properties>
<fabric8io.version>6.7.1</fabric8io.version>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -70,7 +70,7 @@
<configuration>
<java>
<googleJavaFormat>
<version>1.15.0</version>
<version>1.18.1</version>
<style>AOSP</style>
</googleJavaFormat>
</java>
Expand Down