Better exception message when loading package fails #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the stack traces when a package failed to load (due to miscellanies reasons) would not include which package that failed, thus making it hard to debug and fixing the error. This commit fixes this by including the resource description in the stack trace and wrapping the original stack trace. A test util class for tapping system err is added for the ability to verify the solution, as the exception is just logged and not propagated out of the class. Coding style is kept as close to the rest of the other files as possible. Solves issue #228
Small cleanup to make the code more understandable. The relative path is overwritten by the createRelative method in the next call.
|
Very nice, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #228
Previously the stack traces when a package failed to load (due to miscellanies reasons) would not include which package that failed, thus making it hard to debug and fixing the error.
This PR fix this by including the resource description in the stack trace and wrapping the original stack trace.
Se commit message for more details.
Ex stack trace after change (from test):
