Prevent crash when invalid manifest (#247)

InseeFrLab · Aug 31, 2023 · 2dc4db9 · 2dc4db9
1 parent 777a0af
commit 2dc4db9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -8,4 +8,5 @@ node_modules
 *.iml
 .vscode
 onyxia-api/src/main/resources/application.properties.local
-onyxia-api/src/main/resources/regions.json.local
+onyxia-api/src/main/resources/regions.json.local
+target
diff --git a/onyxia-api/src/main/java/fr/insee/onyxia/api/services/impl/HelmAppsService.java b/onyxia-api/src/main/java/fr/insee/onyxia/api/services/impl/HelmAppsService.java
@@ -352,9 +352,20 @@ private Service getServiceFromRelease(
             Region region, HelmLs release, String manifest, User user) {
         KubernetesClient client = kubernetesClientProvider.getUserClient(region, user);
 
-        List<String> urls = getServiceUrls(region, manifest, client);
         Service service = new Service();
-        service.setUrls(urls);
+
+        try {
+            List<String> urls = getServiceUrls(region, manifest, client);
+            service.setUrls(urls);
+        } catch (Exception e) {
+            System.out.println(
+                    "Warning : Failed to retrieve URLS for release "
+                            + release.getName()
+                            + " namespace "
+                            + release.getNamespace());
+            e.printStackTrace();
+            service.setUrls(List.of());
+        }
 
         service.setInstances(1);