Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UP] ⬆️ Update S3Operator chart to support new s3Operator ver… #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Donatien26
Copy link
Contributor

…sion

@Donatien26 Donatien26 force-pushed the update-s3operator-chart branch 3 times, most recently from 335809d to 0f097ff Compare October 18, 2024 13:41
Copy link
Contributor

@sathieu sathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments ...

s3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s3:
s3instance:

# secretRef: "my-s3-operator-auth-secret"
# caCertSecretRef: "my-s3-operator-cert-secret"
# allowedNamespaces: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# allowedNamespaces: ""
# allowedNamespaces: []

{{- include "s3-operator.labels" . | nindent 4 }}
name: default-s3instance-credentials
type: Opaque
data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data:
stringData:

accessKey: "accessKey"
secretKey: "secretKey"
caCertificatesBase64: base64encodedPEMFormatCACertificate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why base64?

@Donatien26 Donatien26 force-pushed the update-s3operator-chart branch from 0f097ff to cfa4e35 Compare November 5, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants